From owner-freebsd-net@FreeBSD.ORG  Tue Apr 13 12:00:14 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ABC251065704
	for <freebsd-net@hub.freebsd.org>; Tue, 13 Apr 2010 12:00:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 9BE7F8FC29
	for <freebsd-net@hub.freebsd.org>; Tue, 13 Apr 2010 12:00:14 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o3DC0ELq066763
	for <freebsd-net@freefall.freebsd.org>; Tue, 13 Apr 2010 12:00:14 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o3DC0ElS066762;
	Tue, 13 Apr 2010 12:00:14 GMT (envelope-from gnats)
Date: Tue, 13 Apr 2010 12:00:14 GMT
Message-Id: <201004131200.o3DC0ElS066762@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Gleb Smirnoff <glebius@FreeBSD.org>
Cc: 
Subject: Re: kern/145462
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Gleb Smirnoff <glebius@FreeBSD.org>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2010 12:00:14 -0000

The following reply was made to PR kern/145462; it has been noted by GNATS.

From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Aleksey <otim@mail.ru>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/145462
Date: Tue, 13 Apr 2010 15:36:58 +0400

  IMO, this patch would be better:
 
 Index: ng_ipfw.c
 ===================================================================
 --- ng_ipfw.c   (revision 206495)
 +++ ng_ipfw.c   (working copy)
 @@ -264,11 +264,8 @@
          * Node must be loaded and corresponding hook must be present.
          */
         if (fw_node == NULL || 
 -          (hook = ng_ipfw_findhook1(fw_node, fwa->rule.info)) == NULL) {
 -               if (tee == 0)
 -                       m_freem(*m0);
 +          (hook = ng_ipfw_findhook1(fw_node, fwa->rule.info)) == NULL)
                 return (ESRCH);         /* no hook associated with this rule */
 -       }
  
         /*
          * We have two modes: in normal mode we add a tag to packet, which is
 
 
 Can you please test it and if you don't mind I will commit it.
 
 -- 
 Totus tuus, Glebius.