From owner-svn-src-all@FreeBSD.ORG Sat Sep 11 13:23:18 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5EC9106564A; Sat, 11 Sep 2010 13:23:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 256738FC08; Sat, 11 Sep 2010 13:23:17 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o8BDNELB093497 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 11 Sep 2010 16:23:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o8BDNE9O098866; Sat, 11 Sep 2010 16:23:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o8BDNERZ098865; Sat, 11 Sep 2010 16:23:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 11 Sep 2010 16:23:14 +0300 From: Kostik Belousov To: Rui Paulo Message-ID: <20100911132314.GZ2465@deviant.kiev.zoral.com.ua> References: <201009111258.o8BCwViM097096@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DHd0DHvhbdljNSqO" Content-Disposition: inline In-Reply-To: <201009111258.o8BCwViM097096@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_20, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212465 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Sep 2010 13:23:18 -0000 --DHd0DHvhbdljNSqO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 11, 2010 at 12:58:31PM +0000, Rui Paulo wrote: > Author: rpaulo > Date: Sat Sep 11 12:58:31 2010 > New Revision: 212465 > URL: http://svn.freebsd.org/changeset/base/212465 >=20 > Log: > Avoid a LOR (sleepable after non-sleepable) in > fasttrap_tracepoint_enable(). > =20 > Sponsored by: The FreeBSD Foundation >=20 > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c >=20 > Modified: head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c Sat Se= p 11 12:51:01 2010 (r212464) > +++ head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c Sat Se= p 11 12:58:31 2010 (r212465) > @@ -591,7 +591,9 @@ fasttrap_tracepoint_enable(proc_t *p, fa > * Before we make any modifications, make sure we've imposed a barrier > * on the generation in which this probe was last modified. > */ > + PROC_UNLOCK(p); > fasttrap_mod_barrier(probe->ftp_gen); > + PROC_LOCK(p); > =20 > bucket =3D &fasttrap_tpoints.fth_table[FASTTRAP_TPOINTS_INDEX(pid, pc)]; > =20 I suspect that you should hold the process around unlocked region. fasttrap_pid_enable() also does unlock, so it might be better to hold the process immediately after pfind(). --DHd0DHvhbdljNSqO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkyLgsIACgkQC3+MBN1Mb4jlVwCg48F2wwouG9NZcvAHlW/RulZC lcYAnj6pianC5qnRWHzP9NxG5Z554qi7 =JC/b -----END PGP SIGNATURE----- --DHd0DHvhbdljNSqO--