From owner-cvs-all@FreeBSD.ORG Sat Oct 9 15:13:50 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A622B16A4CE; Sat, 9 Oct 2004 15:13:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 990D643D2D; Sat, 9 Oct 2004 15:13:50 +0000 (GMT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i99FDoa3001286; Sat, 9 Oct 2004 15:13:50 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i99FDoFT001285; Sat, 9 Oct 2004 15:13:50 GMT (envelope-from mtm) Message-Id: <200410091513.i99FDoFT001285@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 9 Oct 2004 15:13:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/lib/libthr/thread thr_mutex.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Oct 2004 15:13:50 -0000 mtm 2004-10-09 15:13:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) lib/libthr/thread thr_mutex.c Log: ---------------------------- revision 1.32 date: 2004/09/22 18:51:16; author: mtm; state: Exp; lines: +1 -14 Remove vestiges of libthr's signal mangling past. This fixes that last known problem with mysql on libthr: not being able to kill mysqld. ---------------------------- revision 1.31 date: 2004/09/22 16:53:23; author: mtm; state: Exp; lines: +6 -27 The SUSv3 function say that the affected functions MAY FAIL, if the specified mutex is invalid. In spec parlance 'MAY FAIL' means it's up to the implementor. So, remove the check for NULL pointers for two reasons: 1. A mutex may be invalid without necessarily being NULL. 2. If the pointer to the mutex is NULL core-dumping in the vicinity of the problem is much much much better than failing in some other part of the code (especially when the application doesn't check the return value of the function that you oh so helpfully set to EINVAL). ============================================================================= Approved by: re/scottl Revision Changes Path 1.30.2.1 +7 -41 src/lib/libthr/thread/thr_mutex.c