From owner-freebsd-net@freebsd.org Tue Sep 17 18:27:33 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 36C8012B2EB for ; Tue, 17 Sep 2019 18:27:33 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Xs6D1Y4Dz4Vj5 for ; Tue, 17 Sep 2019 18:27:31 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pg1-x544.google.com with SMTP id i18so2432967pgl.11 for ; Tue, 17 Sep 2019 11:27:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8VCWUkkvxqKAf0XK37SN5yEXepzVqFlopI6ZVSVgw+s=; b=o6uek/zbLzCiEMXjPcH6l/70P5mYmxh+YGEx1Gj6ZbTNKE0t8GHcdeqaWt+CIN78S3 fmNyVqcBQLcBSP4Stt3TfQ/4faFceDtbxGjnZ75CJYoUmAiEV/pqI/1LJ46kw2/jJOA+ B+lGXdKGlhoAuNbtnhnmm8p8++J3Xo22tB1KCLyzuMa17gLwvpT4Yv5pBcIQHIJukbKJ 1NxNgKR/iTVHh9GNqTHtb8Ffqj+aRINpLvxMHENHtKUj1ryOC5yuEYT7ZqWqtzDPPW1L m4+U1+2CyVLd73U9EyQHPmOJg5ndkxf3XgwKXf15BF7nSZGGe/NUpJJR7xnzjDSBcEb8 +45A== X-Gm-Message-State: APjAAAU/PEudTl66rXGQIhvYTl6Bx3k0G9OMtcKpeLJZXx5XbKaIS1oP OAv382o93nrGUxRgZwN9/sOdVw== X-Google-Smtp-Source: APXvYqzvugMj9ZP/H3OOswR0X6ZcdO4hgZrwu3fbaGeT30zsS+lmet4S2KOwyCKHZ/FN40yF8IxmKw== X-Received: by 2002:a17:90a:9409:: with SMTP id r9mr6424891pjo.10.1568744850271; Tue, 17 Sep 2019 11:27:30 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::b145? ([2607:fb10:7021:1::b145]) by smtp.gmail.com with ESMTPSA id 127sm4610528pfy.56.2019.09.17.11.27.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 11:27:29 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Tue, 17 Sep 2019 11:27:27 -0700 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Content-Transfer-Encoding: quoted-printable Message-Id: <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46Xs6D1Y4Dz4Vj5 X-Spamd-Bar: ------------ X-Spamd-Result: default: False [-12.54 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.04)[ip: (-0.22), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 18:27:33 -0000 Pacing is provided by tcp_hpts.c. The current linux patches do not have to have fq.. they built an alternate means of doing pacing into bbr. In either case our testing has shown that our pacing is more accurate = than either fq or the internal pacer :) R > On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >=20 > Thanks Randall. > I was able to apply the patch - now rebuilding the kernel. Would = update on how it goes. >=20 > BTW, is there any description on how lack of tc_fq under FreeBSD is = compensated here? > The original BBR patches on Linux show that as a must-have? Is that = functionality implemented via tcp_ratelimit.[ch]? >=20 > Any pointers to existing presentations/discussions highly appreciated? >=20 > Thanks a lot. >=20 > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > You should be able to compile it against the current head. I re-doing = that now (had an > issue with my machine and had to roll it back to a backup). >=20 > When I put the patch up on Sept 10th it complied with and without BBR = on whatever > was that rev.. >=20 > Looking in the commit logs that would have been around 352191 >=20 > Hope that helps >=20 > R >=20 > > On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > >=20 > > Hi Randall, > >=20 > > Thanks for releasing BBR patch: > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 > >=20 > > Could you please let me know what SVN/GIT label tag this is based = on? I would like to patch and experiment with it. I couldn't find this = info in the released patch. > >=20 > > Thanks a lot!=20 > >=20 > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > > rrs@ has just posted the BBR patch to phabricator: > >=20 > > https://reviews.freebsd.org/D21582 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com