From nobody Wed Nov 2 17:47:15 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N2Z8h20dqz4gVWT; Wed, 2 Nov 2022 17:47:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N2Z8h1FYfz41pf; Wed, 2 Nov 2022 17:47:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667411236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QSH1nQ4FdSQEd49RtZ4o383ovBiEACMet3AywB22qKA=; b=eP7fjompab3OnvfjmemmNytfW5wGX+xyOO1YqosSPrkK7o3nFY5H/PYQpnaElsqo+SnAMt 01Zq4ADramH3PiGkRs8gPSbF2GeQp7YZi6tUyQmDZThZBbAapDGIL3vWoSGdqyQHYo76lt /8Qx5LNdWXBFPWJnHvw0ncIJQOXwgfTGik4XNCnFj8QdnXu40dbx4MWj42ZJHhwGhX9gLX FhOVk//F1l/FxrdDvoZiuSVTRaooKd36k+DTk9oogfP6gvzCF8+vIry98p7tuUwneEX1wZ +tRr1yrtj+L1GOTy311IuwZmlM+i7LczIqL+xGwRA3ewK6ry7fSFlTbfFX0JkA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N2Z8h0GS0z157j; Wed, 2 Nov 2022 17:47:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2A2HlFA8022690; Wed, 2 Nov 2022 17:47:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2A2HlFbZ022689; Wed, 2 Nov 2022 17:47:15 GMT (envelope-from git) Date: Wed, 2 Nov 2022 17:47:15 GMT Message-Id: <202211021747.2A2HlFbZ022689@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: c036339ddf0c - main - ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c036339ddf0cf80164f41ea31f1d8d27f4a068a9 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667411236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QSH1nQ4FdSQEd49RtZ4o383ovBiEACMet3AywB22qKA=; b=s70szMnZQ7cUNkhZjOYP+6LqHKlzAj9Rp+E+qPzGh8npM/7Y/Kk/AdxFGKw4FEYqGShori rX3NJUdtcWUfvca1gHWyOSaQzhwbpFW+eTijhTc0B2e6MtDcOKvwpB/s4Z0Sff/Zq7Lg1I hoVuZwDE4ofcIViPLwn+jUbauFuufoZBkXcGZ+pq9HoYfrS3kAjtWtuhWUTM2BD9X7SjR/ GhRU1iCcQYfKZoBmeaYknb7qmcejQNbsHhUd+HaKPPwQBUW93YORGU7oFF5AOhy+5l7rHc d5OoDEzl0QBIYT5UjMGFs4f9ic1HnnomjMy67Fk0cgjtivSJ3JeotA/9MO/zKA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667411236; a=rsa-sha256; cv=none; b=ZueJfx+YR95bLWXpDS0l9esqgGIEkJJscXOnZseqjz+3NARvocgtu/JQAHRWGbO12P+52V ddnLKZiessiAMqQDcv+QSg1jDnKsbtcdBX4mxHmuUkFT+k9cMOSWhKwf2+dqsR+gTkC5ki s8Stjyxb0aBVS5VG0TFk1sicYUBJJHh962PfK7W/syZ3BDsajvrjmtgq92//QX77P2TYcC SPI1W5QjiXrVE1iQQwAxGKFZKxAUbYwqJ5SLan10Bz+iIIl+qV6KirO+7/A2Sx+QPrQdWB 43RaZ+Wj/BkI/YL4GjLPuVBz//zrdn1cxZ7fPD/B6zeLKBqNmxYRUAFUCbQhuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c036339ddf0cf80164f41ea31f1d8d27f4a068a9 commit c036339ddf0cf80164f41ea31f1d8d27f4a068a9 Author: Mark Johnston AuthorDate: 2022-11-02 17:20:11 +0000 Commit: Mark Johnston CommitDate: 2022-11-02 17:46:24 +0000 ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE They could potentially be abused to overwrite kernel memory, so shouldn't be accessible when mac_ddb is loaded. Reviewed by: mhorne Fixes: bc4ea61d55cb ("ddb: tag core commands with DB_CMD_MEMSAFE") Sponsored by: Juniper Networks, Inc. Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D37105 --- sys/ddb/db_command.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sys/ddb/db_command.c b/sys/ddb/db_command.c index ab7bec8f2ffc..0ddbf5f49629 100644 --- a/sys/ddb/db_command.c +++ b/sys/ddb/db_command.c @@ -126,15 +126,15 @@ static struct db_command db_cmds[] = { DB_CMD("set", db_set_cmd, CS_OWN|DB_CMD_MEMSAFE), DB_CMD("write", db_write_cmd, CS_MORE|CS_SET_DOT), DB_CMD("w", db_write_cmd, CS_MORE|CS_SET_DOT), - DB_CMD("delete", db_delete_cmd, DB_CMD_MEMSAFE), - DB_CMD("d", db_delete_cmd, DB_CMD_MEMSAFE), + DB_CMD("delete", db_delete_cmd, 0), + DB_CMD("d", db_delete_cmd, 0), DB_CMD("dump", db_dump, DB_CMD_MEMSAFE), - DB_CMD("break", db_breakpoint_cmd, DB_CMD_MEMSAFE), - DB_CMD("b", db_breakpoint_cmd, DB_CMD_MEMSAFE), - DB_CMD("dwatch", db_deletewatch_cmd, DB_CMD_MEMSAFE), - DB_CMD("watch", db_watchpoint_cmd, CS_MORE|DB_CMD_MEMSAFE), - DB_CMD("dhwatch", db_deletehwatch_cmd, DB_CMD_MEMSAFE), - DB_CMD("hwatch", db_hwatchpoint_cmd, DB_CMD_MEMSAFE), + DB_CMD("break", db_breakpoint_cmd, 0), + DB_CMD("b", db_breakpoint_cmd, 0), + DB_CMD("dwatch", db_deletewatch_cmd, 0), + DB_CMD("watch", db_watchpoint_cmd, CS_MORE), + DB_CMD("dhwatch", db_deletehwatch_cmd, 0), + DB_CMD("hwatch", db_hwatchpoint_cmd, 0), DB_CMD("step", db_single_step_cmd, DB_CMD_MEMSAFE), DB_CMD("s", db_single_step_cmd, DB_CMD_MEMSAFE), DB_CMD("continue", db_continue_cmd, DB_CMD_MEMSAFE),