Date: Tue, 10 Oct 2023 23:28:26 -0400 From: Alexander Motin <mav@FreeBSD.org> To: Ravi Pokala <rpokala@freebsd.org>, Martin Matuska <mm@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: 26103ccba8b7 - main - zfs: enable block cloning by default Message-ID: <c5bafe02-a52d-dbfb-4ae4-bfcf03b32ffb@FreeBSD.org> In-Reply-To: <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com> References: <202310102247.39AMlsjX018898@gitrepo.freebsd.org> <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ravi, It was disabled because 6 months ago when it was introduced there were some bug reports, and people preferred to stay away rather than debug it. Since then Linux support was added with respective testing and fixing. Several bugs found during FreeBSD testing were addressed, and all the tests are passing clean now. In upstream OpenZFS this feature was never actually disabled, and the release of OpenZFS 2.2.0 including it should be officially tagged nearest days. So we feel it is time for another try. At least until any other issues are reported, there is no reason for it to stay disabled. On 10.10.2023 22:44, Ravi Pokala wrote: > Hi Martin, > > The commit message says "what", not "why". > > Why was block cloning disabled by default before, and why is it being enabled now? > > Thanks, > > Ravi (rpokala@) > > -----Original Message----- > From: <owner-src-committers@freebsd.org <mailto:owner-src-committers@freebsd.org>> on behalf of Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org>> > Date: Wednesday, October 11, 2023 at 04:17 > To: <src-committers@FreeBSD.org <mailto:src-committers@FreeBSD.org>>, <dev-commits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-commits-src-main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD.org>> > Subject: git: 26103ccba8b7 - main - zfs: enable block cloning by default > > > The branch main has been updated by mm: > > > URL: https://cgit.FreeBSD.org/src/commit/?id=26103ccba8b75038bd83773268524ac814bfa334 <https://cgit.FreeBSD.org/src/commit/?id=26103ccba8b75038bd83773268524ac814bfa334>; > > > commit 26103ccba8b75038bd83773268524ac814bfa334 > Author: Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org>> > AuthorDate: 2023-10-10 22:43:35 +0000 > Commit: Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org>> > CommitDate: 2023-10-10 22:43:35 +0000 > > > zfs: enable block cloning by default > > > Discussed with: markj > Reviewed by: mav > Tested by: mm (FreeBSD test suite + OpenZFS test suite) > MFC after: 2 months > Differential Revision: https://reviews.freebsd.org/D41991 <https://reviews.freebsd.org/D41991>; > --- > sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > index 8969fd6a54bd..09e18de81748 100644 > --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > @@ -89,7 +89,7 @@ int zfs_debug_level; > SYSCTL_INT(_vfs_zfs, OID_AUTO, debug, CTLFLAG_RWTUN, &zfs_debug_level, 0, > "Debug level"); > > > -int zfs_bclone_enabled; > +int zfs_bclone_enabled = 1; > SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, > &zfs_bclone_enabled, 0, "Enable block cloning"); > > > > > > -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c5bafe02-a52d-dbfb-4ae4-bfcf03b32ffb>