From owner-freebsd-ports@FreeBSD.ORG  Sun Jul 24 17:18:48 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 27864106564A
	for <ports@freebsd.org>; Sun, 24 Jul 2011 17:18:48 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com
	[209.85.210.182])
	by mx1.freebsd.org (Postfix) with ESMTP id EA2F48FC08
	for <ports@freebsd.org>; Sun, 24 Jul 2011 17:18:47 +0000 (UTC)
Received: by iyb11 with SMTP id 11so5153479iyb.13
	for <ports@freebsd.org>; Sun, 24 Jul 2011 10:18:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type;
	bh=KrVCyJ180AG3Oy/L7QpIx01MVJ9ib6XvPxo7KL1YstI=;
	b=IZFxODZ68ARXEC1HrfJLmUEQGLzE+RLa76f7RGXz7TOUWgOufbafr28mcPaBApoV/H
	oJ5kQZ5H6/r36QindjVV7WMGPQf+PME4qDgkmS7nNO7SlsQpg0EoE0kEhF89XIU1G9oZ
	Yzd/oCG5ICYzaOiBL4vH3Inc7gNhWgYHEJU9I=
Received: by 10.231.118.18 with SMTP id t18mr3555920ibq.60.1311527926068; Sun,
	24 Jul 2011 10:18:46 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.231.67.211 with HTTP; Sun, 24 Jul 2011 10:18:16 -0700 (PDT)
In-Reply-To: <89792658-145E-4548-B930-C847FCE6E990@vandalon.nl>
References: <89792658-145E-4548-B930-C847FCE6E990@vandalon.nl>
From: Chris Rees <crees@freebsd.org>
Date: Sun, 24 Jul 2011 18:18:16 +0100
X-Google-Sender-Auth: UaWhEDIM71uSpEcH3OXPIFFx3VI
Message-ID: <CADLo83-kgdCBXO0U5qBwt=TnYuXy_VZLCf2ChzrKui8P=ehV=w@mail.gmail.com>
To: Joris Vandalon <joris@vandalon.nl>
Content-Type: text/plain; charset=ISO-8859-1
Cc: ports@freebsd.org
Subject: Re: Port submit status (Port/157426).
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jul 2011 17:18:48 -0000

On 24 July 2011 12:04, Joris Vandalon <joris@vandalon.nl> wrote:
> Hi,
>
> I submitted a freebsd port (157426) the 30th of may.
> Now I know I should be patient but I was wondering if there is something is wrong with this port since previous ports where always accepted within a month.
>

Hi Joris,

I've replied to the PR, and scanning over it again I've just noticed
that you've patched the distribution's Makefile to make an install
target.

Normally we use something like (in the port's Makefile):

do-install:
<TAB>${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin/
<TAB>${INSTALL_MAN} ${WRKSRC}/${MAN1} ${MAN1PREFIX}/man/man1/

Oops, in patch-config.mk:

UNRAR_LIB=/usr/lcoal/lib

Probably better (rather than hardcoding /usr/local) to use
%%LOCALBASE%% in the patch for the UNRAR_LIB and FUSE_SRC, and
%%PREFIX%% for DESTDIR and then:

post-patch:
<TAB>${REINPLACE_CMD} -e 's,%%LOCALBASE%%,${LOCALBASE},' \
<TAB>       -e 's,%%PREFIX%%,${LOCALBASE},' \
<TAB>       ${WRKSRC}/config.mk

If you fix these issues I'll take it.

Chris