From owner-svn-src-head@FreeBSD.ORG Fri Dec 20 21:38:52 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 51B94324; Fri, 20 Dec 2013 21:38:52 +0000 (UTC) Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu [18.7.68.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8E1B21D71; Fri, 20 Dec 2013 21:38:51 +0000 (UTC) X-AuditID: 12074425-f79906d000000cf9-e8-52b4b8e4c36b Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) (using TLS with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id 83.E9.03321.4E8B4B25; Fri, 20 Dec 2013 16:38:44 -0500 (EST) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id rBKLch2w018361; Fri, 20 Dec 2013 16:38:43 -0500 Received: from multics.mit.edu (system-low-sipb.mit.edu [18.187.2.37]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id rBKLcfte031360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 20 Dec 2013 16:38:42 -0500 Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id rBKLceKL021585; Fri, 20 Dec 2013 16:38:40 -0500 (EST) Date: Fri, 20 Dec 2013 16:38:40 -0500 (EST) From: Benjamin Kaduk To: Neel Natu Subject: Re: svn commit: r259641 - in head/sys/amd64: amd64 include vmm/intel In-Reply-To: Message-ID: References: <201312200550.rBK5oNmw098487@svn.freebsd.org> User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLIsWRmVeSWpSXmKPExsUixCmqrftkx5Ygg8btqhbHHh5lt/izbCWj xZ/2KSwWfzYtZLVo+rKAyYHVY8an+SweO2fdZQ9giuKySUnNySxLLdK3S+DK6FwtXDCfu2LX 7UesDYwPOboYOTkkBEwk+s4dZYKwxSQu3FvP1sXIxSEkMJtJYt/7LVDORkaJz2sfsUI4h5gk DvU2s0A4DYwS/funsYH0swhoS7w/c40ZxGYTUJGY+WYjUJyDQ0RASeLetmKQemaBF4wSTYfn MYLUCAv4Sxx6Nh2sl1MgUKLn5UUWEJtXwFFix7SLUKsPM0pc2fEcbKiogI7E6v1ToIoEJU7O fAJmMwtYSpz7c51tAqPgLCSpWUhSCxiZVjHKpuRW6eYmZuYUpybrFicn5uWlFula6OVmluil ppRuYgSFMruL6g7GCYeUDjEKcDAq8fBKRG4JEmJNLCuuzD3EKMnBpCTKy7oNKMSXlJ9SmZFY nBFfVJqTWnyIUYKDWUmEd94EoBxvSmJlVWpRPkxKmoNFSZz3Fod9kJBAemJJanZqakFqEUxW hoNDSYL37HagRsGi1PTUirTMnBKENBMHJ8hwHqDhl0FqeIsLEnOLM9Mh8qcYFaXEeQWAyUJI ACSRUZoH1wtLNa8YxYFeEeY9CNLOA0xTcN2vgAYzAQ02XrsJZHBJIkJKqoFxvdDCFM9V+qaq /BbJ9TofN6T4RXQatYWdupSYeDT1X87i+zO4+BIirm06XJ99z9D98YJboQwmYncXaEY9f2js 4Wu8caeZbfqLTr+SuTJ3Tb4u253Gcvwb48TF0549lTjXG3Z1wp/iCauPq//8Uh7wqnv2yfR2 Xu/Y4/qvBBOncknX2mm3iq1RYinOSDTUYi4qTgQAB4fV5RADAAA= Cc: Benjamin Kaduk , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Dec 2013 21:38:52 -0000 On Fri, 20 Dec 2013, Neel Natu wrote: > Hi Ben, > > On Fri, Dec 20, 2013 at 10:27 AM, Benjamin Kaduk wrote: >> On Thu, Dec 19, 2013 at 9:50 PM, Neel Natu wrote: >>> >>> Author: neel >>> Date: Fri Dec 20 05:50:22 2013 >>> New Revision: 259641 >>> URL: http://svnweb.freebsd.org/changeset/base/259641 >>> >>> Log: >>> Re-arrange bits in the amd64/pmap 'pm_flags' field. >>> >>> The least significant 8 bits of 'pm_flags' are now used for the IPI >>> vector >>> to use for nested page table TLB shootdown. >>> >>> Previously we used IPI_AST to interrupt the host cpu which is >>> functionally >>> correct but could lead to misleading interrupt counts for AST handler. >>> The >>> AST handler was also doing a lot more than what is required for the >>> nested >>> page table TLB shootdown (EOI and IRET). >> >> >> This represents a KBI change, does it not? Should __FreeBSD_version be >> bumped? >> > > I was under the impression that a bump would be required only if this > change is MFCed to a stable branch. I could be wrong about this and if > so would be happy to rectify it. I guess KBI is probably okay, that's true. I have had a lot of headaches with KPI changes on -current and third-party modules, so I am a bit sensitive. I'm also recovering from a laptop theft while on vacation, and thus a bit discombobulated. Thanks, Ben