From owner-svn-src-head@freebsd.org Fri Nov 2 16:18:59 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE2E410FC392; Fri, 2 Nov 2018 16:18:59 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 78DF672CD2; Fri, 2 Nov 2018 16:18:59 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 9063E3C475F; Fri, 2 Nov 2018 16:18:58 +0000 (UTC) Date: Fri, 2 Nov 2018 16:18:58 +0000 From: Brooks Davis To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340055 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/fs/ext2fs sys/fs/fuse sys/fs/nandfs sys/fs/nfs sys/fs/nfsclient sys/fs/tmpfs sys/kern sys/sys sys/uf... Message-ID: <20181102161858.GC79858@spindle.one-eyed-alien.net> References: <201811021442.wA2EgbVc062099@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qcHopEYAB45HaUaB" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 16:19:00 -0000 --qcHopEYAB45HaUaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 02, 2018 at 04:49:00PM +0200, Andriy Gapon wrote: > On 02/11/2018 16:42, Brooks Davis wrote: > > Author: brooks > > Date: Fri Nov 2 14:42:36 2018 > > New Revision: 340055 > > URL: https://svnweb.freebsd.org/changeset/base/340055 > >=20 > > Log: > > Make vop_symlink take a const target path. > > =20 > > This will enable callers to take const paths as part of syscall > > decleration improvements. > > =20 > > Where doing so is easy and non-distruptive carry the const through > > implementations. In UFS the value is passed to an interface that must > > take non-const values. In ZFS, const poisoning would touch code shared > > with upstream and it's not worth adding diffs. >=20 > zfs_vnops.c is already sufficiently different from upstream (because of q= uite > different VFS models), so a small difference in zfs_symlink's signature w= ould > not be too bad. Good to know. When I hit modifying three files I stopped. I'll keep this in the back of my mind as a possible improvement. Thanks, Brooks --qcHopEYAB45HaUaB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJb3HjxAAoJEKzQXbSebgfAcgAH/0SKXqqU3WlIpQvG3m0CFuAw tZbiyp/ZRhrbltGmTps9R8i3cAvc7b7LEDbiUffJdwg7JY+OsdTW2zXHOPHSPMl0 IZDfyYixhCvQhGh0EQq6VZESUB67ff0oz5yg6N/i8f7P8pJbrc1hEz2VpLEPCJhL /fE65yYG/CmuHaHtLEmfU8aWIr/CrNI0SYrfA/V2YCYflugmegG8lT8qO0SdtA0R VdW1EbrawpD14cFgm/3Rg3K+FV6xqbuuGLnLYXNN16d1KRJ0IIpxVsrZsu+7GMHx g5iSFO+xkvD+VETvfkNajwTXjxWpC26TFTuOT1UsQWSlZdIbI6zBe3reJXrdVlo= =p3Up -----END PGP SIGNATURE----- --qcHopEYAB45HaUaB--