From owner-svn-src-all@FreeBSD.ORG Fri Oct 7 12:21:50 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5903106564A; Fri, 7 Oct 2011 12:21:50 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id D5C088FC08; Fri, 7 Oct 2011 12:21:50 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p97CLo3j010389; Fri, 7 Oct 2011 12:21:50 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p97CLo6o010387; Fri, 7 Oct 2011 12:21:50 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <201110071221.p97CLo6o010387@svn.freebsd.org> From: Ed Schouten Date: Fri, 7 Oct 2011 12:21:50 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r226099 - head/sys/teken X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2011 12:21:51 -0000 Author: ed Date: Fri Oct 7 12:21:50 2011 New Revision: 226099 URL: http://svn.freebsd.org/changeset/base/226099 Log: Tab should not blank cells. It seems I was under the impression that a tab differs from a single forward tabulation, namely that it blanks the underlying cells. This seems not to be the case. They are identical. This should fix applications like jove(1) that use tabs instead of explicit cursor position setting. Reported by: Brett Glass MFC after: 3 days, after it's tested Modified: head/sys/teken/teken_subr.h Modified: head/sys/teken/teken_subr.h ============================================================================== --- head/sys/teken/teken_subr.h Fri Oct 7 09:51:12 2011 (r226098) +++ head/sys/teken/teken_subr.h Fri Oct 7 12:21:50 2011 (r226099) @@ -595,20 +595,7 @@ static void teken_subr_horizontal_tab(teken_t *t) { - if (t->t_stateflags & TS_CONS25) { - teken_subr_cursor_forward_tabulation(t, 1); - } else { - teken_rect_t tr; - - tr.tr_begin = t->t_cursor; - teken_subr_cursor_forward_tabulation(t, 1); - tr.tr_end.tp_row = tr.tr_begin.tp_row + 1; - tr.tr_end.tp_col = t->t_cursor.tp_col; - - /* Blank region that we skipped. */ - if (tr.tr_end.tp_col > tr.tr_begin.tp_col) - teken_funcs_fill(t, &tr, BLANK, &t->t_curattr); - } + teken_subr_cursor_forward_tabulation(t, 1); } static void