Date: Fri, 24 Sep 2004 21:54:19 +0200 From: Thierry Thomas <thierry@FreeBSD.org> To: Igor Pokrovsky <ip@doom.homeunix.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/72002: Update port: graphics/deng dependency fix Message-ID: <20040924195419.GA88434@graf.pompo.net> In-Reply-To: <20040924181639.GA10471@doom.homeunix.org> References: <200409231915.i8NJFRKA049951@freefall.freebsd.org> <20040924181639.GA10471@doom.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--VbJkn9YxBvnuCH5J
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Le Ven 24 sep 04 =E0 20:16:39 +0200, Igor Pokrovsky <ip@doom.homeunix.org>
=E9crivait=A0:
> You are right. Your patch is fine. Commit it please.
Thanks Igor, I'm going to ask portmgr for approval.
> However I have a question. Why bsd.port.pre.mk is not required in this ca=
se.
> I thought that we need it to resolve ${LOCALBASE} on the early stage.=20
> Am I wrong?
$LOCALBASE is a simple variable, always evaluated. I don't know why
bsd.port.pre.mk was required, perhaps there was previously a complex
test? By "complex", I mean some variable not directly evaluated, like
$OSVERSION, which implies bsd.port.pre.mk.
> And another thing. I used BUILD_DEPENDS and RUN_DEPENDS together instead
> of simply LIB_DEPENDS because AFAIR portlint was complaining about
> placing LIB_DEPENDS so late in makefile. So I see it's not the case now?
Because you was using strict "=3D" and now I'm using "+=3D".
Regards,
--=20
Th. Thomas.
--VbJkn9YxBvnuCH5J
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBVHtrc95pjMcUBaIRAkTHAJ9ZIVJd4vVi3zwwh1/XnJmuE/hkVgCfbQjH
1vRZF/6mrcpHRW/cf+TvotE=
=pk43
-----END PGP SIGNATURE-----
--VbJkn9YxBvnuCH5J--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040924195419.GA88434>