From owner-cvs-all@FreeBSD.ORG Thu Aug 4 12:23:22 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7636116A41F; Thu, 4 Aug 2005 12:23:22 +0000 (GMT) (envelope-from bob@immure.com) Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id C802443D49; Thu, 4 Aug 2005 12:23:21 +0000 (GMT) (envelope-from bob@immure.com) Received: from pimout3-ext.prodigy.net (pimout3-int.prodigy.net [207.115.4.218]) by ylpvm29.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id j74CMmsx023341; Thu, 4 Aug 2005 08:22:48 -0400 X-ORBL: [66.136.206.1] Received: from maul.immure.com (adsl-66-136-206-1.dsl.austtx.swbell.net [66.136.206.1]) by pimout3-ext.prodigy.net (8.13.4 outbound domainkey aix/8.13.4) with ESMTP id j74CNKt6124412; Thu, 4 Aug 2005 08:23:20 -0400 Received: from luke.immure.com (luke.immure.com [10.1.132.3]) by maul.immure.com (8.13.3/8.12.11) with ESMTP id j74CNDe1052059; Thu, 4 Aug 2005 07:23:13 -0500 (CDT) (envelope-from bob@immure.com) Received: from luke.immure.com (localhost [127.0.0.1]) by luke.immure.com (8.13.1/8.13.1) with ESMTP id j74CNDb8087786; Thu, 4 Aug 2005 07:23:13 -0500 (CDT) (envelope-from bob@luke.immure.com) Received: (from bob@localhost) by luke.immure.com (8.13.1/8.12.11/Submit) id j74CNDbq087785; Thu, 4 Aug 2005 07:23:13 -0500 (CDT) (envelope-from bob) Date: Thu, 4 Aug 2005 07:23:13 -0500 From: Bob Willcox To: Ollivier Robert Message-ID: <20050804122313.GA87318@luke.immure.com> References: <200505261057.j4QAv4oU071149@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200505261057.j4QAv4oU071149@repoman.freebsd.org> User-Agent: Mutt/1.5.9i X-immure-MailScanner-Information: Please contact the ISP for more information X-immure-MailScanner: Found to be clean X-MailScanner-From: bob@immure.com Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/chkgrp chkgrp.8 chkgrp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bob Willcox List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2005 12:23:22 -0000 On Thu, May 26, 2005 at 10:57:04AM +0000, Ollivier Robert wrote: > roberto 2005-05-26 10:57:04 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/chkgrp chkgrp.8 chkgrp.c > Log: > - Add further functionality to check for invalid characters > - Remove keyword 'continue' for more indepth error reporting > on each line > - WARNS 6 Clean > > Submitted by: Liam J. Foy > MFC after: 1 week > > Revision Changes Path > 1.15 +6 -5 src/usr.sbin/chkgrp/chkgrp.8 > 1.9 +24 -6 src/usr.sbin/chkgrp/chkgrp.c This change causes NIS /etc/group entries (+ in column one) to be flagged in error. There is a PR (bin/82325) open on this with a proposed fix, but here is a simpler (almost) one-line version that I'm using: Index: chkgrp.c =================================================================== RCS file: /usr/cvs/FreeBSD/src/usr.sbin/chkgrp/chkgrp.c,v retrieving revision 1.9 diff -u -r1.9 chkgrp.c --- chkgrp.c 26 May 2005 10:57:03 -0000 1.9 +++ chkgrp.c 4 Aug 2005 12:11:03 -0000 @@ -106,7 +106,8 @@ } for (cp = f[0] ; *cp ; cp++) { - if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-') { + if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-' && + (cp > f[0] || *cp != '+')) { warnx("%s: line %d: '%c' invalid character", gfn, n, *cp); e++; } Maybe someone has the time to commit a fix for this?? Thanks, Bob -- Bob Willcox The early bird who catches the worm works for someone bob@immure.com who comes in late and owns the worm farm. Austin, TX -- Travis McGee