From owner-svn-ports-head@FreeBSD.ORG  Mon Nov  4 14:26:15 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 3DEC371C;
 Mon,  4 Nov 2013 14:26:15 +0000 (UTC)
 (envelope-from feld@FreeBSD.org)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D351C288B;
 Mon,  4 Nov 2013 14:26:14 +0000 (UTC)
Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46])
 by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 136D520675;
 Mon,  4 Nov 2013 09:26:14 -0500 (EST)
Received: from web3 ([10.202.2.213])
 by compute6.internal (MEProxy); Mon, 04 Nov 2013 09:26:14 -0500
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
 messagingengine.com; h=message-id:from:to:cc:mime-version
 :content-transfer-encoding:content-type:in-reply-to:references
 :subject:date; s=smtpout; bh=1fH6AT87H/ecCjWJsX9P8dJXUcw=; b=qiM
 mjoAevKkgpS6JGp49wZzYu/jMQlUOTlPCTRxLG0vLn11KxrXzJyYljQ+EHhetYTS
 i8rtLOl1W8j0lU1PQduWVnHvrG+sFpdF/3cizd5jbZZk4i+C6M1d6dvtbsQn0Van
 XMWsKS9wjyElTV2Fgqf56o3XDjfXukF+8ysRm1k8=
Received: by web3.nyi.mail.srv.osa (Postfix, from userid 99)
 id D79E610B491; Mon,  4 Nov 2013 09:26:13 -0500 (EST)
Message-Id: <1383575173.23601.42712325.3D04E827@webmail.messagingengine.com>
X-Sasl-Enc: +VpPZtFffc78nMUVAp0IUGOj1o5hFZPBY4jey97EP6bA 1383575173
From: Mark Felder <feld@FreeBSD.org>
To: Eitan Adler <eadler@freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
X-Mailer: MessagingEngine.com Webmail Interface - ajax-d4893488
In-Reply-To: <CAF6rxgmWq6KkR3b5S82Y+6vf7XPv8gnBbz3v+DzP7GZsj=-sPg@mail.gmail.com>
References: <201311030036.rA30aXLv016213@svn.freebsd.org>
 <20131103201410.2f95dc09@kalimero.tijl.coosemans.org>
 <CAF6rxgn4Bj9J+re5V9yZNNZFTyX5o8EWDG7+N4WpJEGbK24Egg@mail.gmail.com>
 <1383574552.17263.42707017.6BE762CA@webmail.messagingengine.com>
 <CAF6rxgmWq6KkR3b5S82Y+6vf7XPv8gnBbz3v+DzP7GZsj=-sPg@mail.gmail.com>
Subject: Re: svn commit: r332567 - head/graphics/apvlv
Date: Mon, 04 Nov 2013 08:26:13 -0600
Cc: svn-ports-head@freebsd.org, Tijl Coosemans <tijl@freebsd.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Nov 2013 14:26:15 -0000

On Mon, Nov 4, 2013, at 8:20, Eitan Adler wrote:
> On Mon, Nov 4, 2013 at 9:15 AM, Mark Felder <feld@freebsd.org> wrote:
> >
> >
> > On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote:
> >> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans <tijl@freebsd.org> wrote:
> >>
> >> > but now PTHREAD_CFLAGS is always empty
> >>
> >> Which is always a mistake.  PTHREAD_CFLAGS should be replaced with
> >> -pthread
> >>
> >>  so you can remove that line and PTHREAD_LIBS is always
> >> > -pthread.
> >>
> >> As should this.
> >>
> >
> > Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and
> > PTHREAD_LIBS into portlint as well.
> >
> > I'm not 100% sure I understand the changes you're proposing -- I'm
> > getting caught up on the wording. Is this diff what you're suggesting?
> 
> Yes.
> 

Thank you. I will commit this change after doing a quick build test to
ensure nothing crazy happens.