From owner-freebsd-net@freebsd.org  Sun Feb  2 21:35:19 2020
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id CFFC023B8F0
 for <freebsd-net@mailman.nyi.freebsd.org>;
 Sun,  2 Feb 2020 21:35:19 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 489klB71wkz3DkJ
 for <freebsd-net@freebsd.org>; Sun,  2 Feb 2020 21:35:18 +0000 (UTC)
 (envelope-from hps@selasky.org)
Received: from hps2020.home.selasky.org (unknown [62.141.129.235])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 5FD8B260072;
 Sun,  2 Feb 2020 22:35:09 +0100 (CET)
Subject: Re: Does sosend() need CURVNET_SET/CURVNET_RESTORE?
To: Rick Macklem <rmacklem@uoguelph.ca>, freebsd-net <freebsd-net@freebsd.org>
References: <YTBPR01MB337446173B7D480145BBB6C6DD010@YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <6ba3e3bd-d844-e685-7062-339e57438748@selasky.org>
Date: Sun, 2 Feb 2020 22:33:19 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <YTBPR01MB337446173B7D480145BBB6C6DD010@YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 489klB71wkz3DkJ
X-Spamd-Bar: ---
Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none;
 spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates
 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org
X-Spamd-Result: default: False [-3.96 / 15.00]; ARC_NA(0.00)[];
 RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0];
 FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain];
 MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[selasky.org];
 TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[];
 RCPT_COUNT_TWO(0.00)[2];
 IP_SCORE(-2.66)[ip: (-9.21), ipnet: 2a01:4f8::/29(-2.53), asn: 24940(-1.55),
 country: DE(-0.02)]; FROM_EQ_ENVFROM(0.00)[];
 R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[];
 ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE];
 MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[];
 RCVD_COUNT_TWO(0.00)[2]
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Feb 2020 21:35:19 -0000

On 2020-02-02 22:22, Rick Macklem wrote:
> Hi,
> 
> The current krpc code calls sosend() and soreceive() without any
> CURVNET_SET()/CURVNET_RESTORE() wrapped around them.
> 
> When I recently used sosend_generic(), it panic'd without them.
> 
> Do they need to be added around sosend()/soreceive()?
> 
> I'll admit to knowing nothing about vnet.
> 
> Thanks, rick

What is the panic backtrace?

Usually one of these tree variants is used:

CURVNET_SET(TD_TO_VNET(td));
CURVNET_SET(ifp->if_vnet);
CURVNET_SET(so->so_vnet);

--HPS