From owner-svn-src-all@FreeBSD.ORG  Thu Oct 28 01:54:05 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2DB7B106566B;
	Thu, 28 Oct 2010 01:54:05 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 1425A8FC13;
	Thu, 28 Oct 2010 01:54:05 +0000 (UTC)
Received: from xyf.my.dom (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9S1s2tD064930;
	Thu, 28 Oct 2010 01:54:02 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4CC9483C.7050507@freebsd.org>
Date: Thu, 28 Oct 2010 09:54:04 +0000
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100630)
MIME-Version: 1.0
To: Garrett Cooper <gcooper@freebsd.org>
References: <201010270232.o9R2Wsu3084553@svn.freebsd.org>	<AANLkTi=2dTVmB8Goj+NXq4F6SmZBNS3bxn8gLjmQ+dfV@mail.gmail.com>	<4CC803A8.3040602@freebsd.org>	<20101027082122.GD1848@garage.freebsd.pl>	<4CC85552.2020100@freebsd.org>	<20101027133307.GQ2392@deviant.kiev.zoral.com.ua>	<AANLkTinzP+tj3y+-r4-+gHgCzg6BJ-ZpWru365zysSEF@mail.gmail.com>	<4CC851CC.80509@freebsd.org>
	<AANLkTikjvMnaLSrc0MWmL5-kMThgBRJ9GDP5ntYUvHsF@mail.gmail.com>
In-Reply-To: <AANLkTikjvMnaLSrc0MWmL5-kMThgBRJ9GDP5ntYUvHsF@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org>,
	svn-src-all@freebsd.org, Andriy Gapon <avg@freebsd.org>,
	svn-src-head@freebsd.org, Kostik Belousov <kostikbel@gmail.com>
Subject: Re: svn commit: r214409 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Oct 2010 01:54:05 -0000

Garrett Cooper wrote:
> On Wed, Oct 27, 2010 at 9:22 AM, Andriy Gapon <avg@freebsd.org> wrote:
>> [patch attachment was lost]
> 
> Ugh... Mailman hates me I guess :(...
> 
>> on 27/10/2010 19:07 Garrett Cooper said the following:
>>>     How about this patch? I implemented this as a readonly tunable and
>> I don't think that it's correct to call it a tunable or use CTLFLAG_RDTUN.
>> As I understand it is a read-only sysctl.
> 
> Converted to CTLFLAG_RD.
> 
>>> sysconf tunable, because (AFAIK) the value that is being tested
>>> shouldn't change during runtime after the system has been booted up,
>>> and figuring that the value wasn't going to change it was better to
>>> lose 4/8 bytes on the kernel stack instead of having to recompute the
>>> value every time in a function call, with the associated lost heap /
>>> stack memory in the process, as the assumption is that this libcall
>>> was going to be called frequently by some programs.
> 
> Thanks!
> -Garrett
> 

The patch looks fine to me. ;-)