From nobody Fri Feb 20 02:24:31 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fHDbN0X3Lz6QRnf for ; Fri, 20 Feb 2026 02:24:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fHDbM6BlCz3PG7 for ; Fri, 20 Feb 2026 02:24:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771554271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hcoTxtX48eaCZGeZSSnyoxXG/zeNeHTOvlmRX17yk/0=; b=DnW762e399crdgL4B8ZZr+eaKG1UYaJwDAmvRUDlPqVl1DmNGm3G2c/k+oVAGrwJA85nSr 8mBt/ahm1kwbl5L3IaQB+OSpn2jjyPsbrhgOb7Zug+K1/MyMghcCAAv6RrJogHeOPKlIwX DaDeuaRIv753eYvulJC+E5qhKJw7jWLU4G7de/58N1sHRKVo8ne+r8ukZOkGwj0ld91Dea 3GUrE4Czgn7eM7UlXWvYXgHBYJuReRUu0JaKjDE0iDyNmJwld+e3fQON+x/6hzusP5Xgag b03hpotQxGbxWgxXb8sm2+xuqYuw8Lt7UWZVGt5MbfA0uh9mA/aXJ0+9UDOqAw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771554271; a=rsa-sha256; cv=none; b=eltzELl8kkXhuFvHPLhUo3sp0tAfzqPmgBwBwU5Q4sOoehq4qj/3hrG1u46JrzBCzt+h0N Bw46xcFccRgLV3nOM3hM0I39Kdo/FbVXa8jf1zRCICH5HOvGwfBHrOHvFK5KtIO0Lw3CU6 gRzVJZikoaKsc5HGs970fifR9+ZsysOeutZ7xxK2Tp5B+kAehb7U8pHrq6RY/oRHwsQf9q 7HnuJ3pIYvHCtxxprAjSXP3lDSerGNzhBV4mssYJP6j4J8/Ao/xE5zLPuwoAheWi5hq8H9 xnzvqzldY1HYp+iIJQTW4u9De4ddtX2koltKjJR0xl/3kQCb/DTLUV7n7hhJFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771554271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hcoTxtX48eaCZGeZSSnyoxXG/zeNeHTOvlmRX17yk/0=; b=wq5UgiIFfrvZSJhHBgK3+Fx6M2EcbmMwyDS8UACHjWY67vza11xvnCIL8mp5+660Fq8iCQ oAGjUVlE5yTJUJN1JzrRrMxK8zV0vnVROqlvfdq0UiKcnDjyZoXzBEY0049ZrfU7mo2e/P aKisk0WJZRhWgfjgziUeJ2WSwgafOLKK0sgjmOLcuEIk9Qky8yRfcneOTuNwEcxMnREgdk 9wL9xCyEthsSnp9pLqx6v6gAYPXGaKecY6SiO3eYZ9O3t00usHuDU1jCMdK9THEyS8jayx 3q3H4HXv7fWoJLPA4QeCts6LMPXcxroywIxQS2Bfbb5uuuXEQlf24UvFoyzRvg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fHDbM5mfgz17dG for ; Fri, 20 Feb 2026 02:24:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 181bb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 20 Feb 2026 02:24:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 15c33b64ac2d - stable/13 - ipfilter: Fix possible overrun List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 15c33b64ac2d6a6201cb819da184d0f4028d7632 Auto-Submitted: auto-generated Date: Fri, 20 Feb 2026 02:24:31 +0000 Message-Id: <6997c5df.181bb.c67eceb@gitrepo.freebsd.org> The branch stable/13 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=15c33b64ac2d6a6201cb819da184d0f4028d7632 commit 15c33b64ac2d6a6201cb819da184d0f4028d7632 Author: Cy Schubert AuthorDate: 2026-02-04 17:27:23 +0000 Commit: Cy Schubert CommitDate: 2026-02-20 02:24:26 +0000 ipfilter: Fix possible overrun The destination buffer is FR_GROUPLEN (16 bytes) in length. When gname is created, the userspace utilities correctly use FR_GROUPLEN as the buffer length. The kernel should also limit its copy operation to FR_GROUPLEN bytes to avoid any user written code from exploiting this vulnerability. Reported by: Ilja Van Sprundel (cherry picked from commit e40817302ebdf89df2f3bcd679fb7f2a18c244dc) --- sys/netpfil/ipfilter/netinet/fil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netpfil/ipfilter/netinet/fil.c b/sys/netpfil/ipfilter/netinet/fil.c index b2d84ce1fefc..cf21c68b7b46 100644 --- a/sys/netpfil/ipfilter/netinet/fil.c +++ b/sys/netpfil/ipfilter/netinet/fil.c @@ -3507,7 +3507,7 @@ ipf_group_add(ipf_main_softc_t *softc, char *group, void *head, u_32_t flags, fg->fg_head = head; fg->fg_start = NULL; fg->fg_next = *fgp; - bcopy(group, fg->fg_name, strlen(group) + 1); + bcopy(group, fg->fg_name, strnlen(group, FR_GROUPLEN) + 1); fg->fg_flags = gflags; fg->fg_ref = 1; fg->fg_set = &softc->ipf_groups[unit][set];