From owner-svn-src-all@freebsd.org Tue Oct 20 18:51:51 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE012A1AA98; Tue, 20 Oct 2015 18:51:50 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BF5CED45; Tue, 20 Oct 2015 18:51:50 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by padhk11 with SMTP id hk11so29115405pad.1; Tue, 20 Oct 2015 11:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=ePRFkS9Ocs/PMgJXhwmP4ZW6EeB74tZcWzbPfi+7fQs=; b=MKdt7ruOpMrbX4msYt05YtGN3dNkt3B2wCPQcnSD+bmP/UUACtdd49MucPOCTIKaY3 beMTfAXE1yzD6YGek499NABn5KE0J3+BcUrXuf21iUl8we9k5zCSBzSz+DoY6r57SfEO 4I7XaJPAK6UTUmMWXnbUhWcTu8CAQXL96xm+kluSEUUt/Gj/VSigHFpOKNoZV/jXqz5h 4HkVCOSJ4xLlymUG3/wOvI+Tt8GMOm4J0L7mjntYr0YbvvM6Apxi/OGcAfWQbsKO9hw2 bv5dp/qs/8IKY7hMNEoJbPQi3DQ/gq+rzVxG44NqSuVgsKDY5Ivq4pPR6bmepPtMxfN8 aOKg== X-Received: by 10.66.160.100 with SMTP id xj4mr5574140pab.39.1445367110279; Tue, 20 Oct 2015 11:51:50 -0700 (PDT) Received: from [10.192.166.0] (stargate.chelsio.com. [67.207.115.98]) by smtp.googlemail.com with ESMTPSA id pq4sm5049351pbc.53.2015.10.20.11.51.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 11:51:48 -0700 (PDT) Subject: Re: svn commit: r289633 - head/sys/ofed/include/linux To: Hans Petter Selasky , John Baldwin References: <201510201602.t9KG2BeA079785@repo.freebsd.org> <1878746.bHLk1ML9QM@ralph.baldwin.cx> <56268A5A.70103@selasky.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Navdeep Parhar Message-ID: <56268D43.6000209@gmail.com> Date: Tue, 20 Oct 2015 11:51:47 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56268A5A.70103@selasky.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 18:51:51 -0000 On 10/20/2015 11:39, Hans Petter Selasky wrote: > Hi, > > On 10/20/15 20:04, John Baldwin wrote: >> On Tuesday, October 20, 2015 04:02:11 PM Hans Petter Selasky wrote: >>> Author: hselasky >>> Date: Tue Oct 20 16:02:11 2015 >>> New Revision: 289633 >>> URL: https://svnweb.freebsd.org/changeset/base/289633 >>> >>> Log: >>> Add missing FreeBSD RCS keyword and SVN properties. >>> >>> Sponsored by: Mellanox Technologies >>> >>> Modified: >>> head/sys/ofed/include/linux/io-mapping.h (contents, props changed) >>> head/sys/ofed/include/linux/io.h (contents, props changed) >>> head/sys/ofed/include/linux/jhash.h (contents, props changed) >>> head/sys/ofed/include/linux/linux_compat.c (contents, props >>> changed) >>> head/sys/ofed/include/linux/linux_idr.c (contents, props changed) >>> head/sys/ofed/include/linux/linux_radix.c (contents, props changed) >>> head/sys/ofed/include/linux/vmalloc.h (contents, props changed) >>> >>> Modified: head/sys/ofed/include/linux/io-mapping.h >>> ============================================================================== >>> >>> --- head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 15:28:02 >>> 2015 (r289632) >>> +++ head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 16:02:11 >>> 2015 (r289633) >>> @@ -1,3 +1,4 @@ >>> +/* $FreeBSD$ */ >>> /*- >>> * Copyright (c) 2010 Isilon Systems, Inc. >>> * Copyright (c) 2010 iX Systems, Inc. >> >> Just a note on style. Most headers put the tag below the license >> block like so >> from : > > I'll fix that. > >> >> /*- >> * Copyright (c) 1997,1998,2003 Doug Rabson >> * All rights reserved. >> * >> ... >> >> * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE >> POSSIBILITY OF >> * SUCH DAMAGE. >> * >> * $FreeBSD: head/sys/sys/bus.h 284088 2015-06-06 17:25:45Z marcel $ >> */ >> >> It would have been nice to be more consistent with the rest of the >> tree. Maybe >> look around next time to see if there is an existing style? >> >>> Modified: head/sys/ofed/include/linux/jhash.h >>> ============================================================================== >>> >>> --- head/sys/ofed/include/linux/jhash.h Tue Oct 20 15:28:02 >>> 2015 (r289632) >>> +++ head/sys/ofed/include/linux/jhash.h Tue Oct 20 16:02:11 >>> 2015 (r289633) >>> @@ -18,6 +18,7 @@ >>> * >>> * I've modified Bob's hash to be useful in the Linux kernel, and >>> * any bugs present are surely my fault. -DaveM >>> + * $FreeBSD$ >>> */ >> >> Please fix this one to leave a blank line before the tag at least. >> > > I tried to make linux/jhash.h similar to dev/cxgb/common/jhash.h, which > are actually duplicate files. cxgb's copy of jhash.h does have a blank line before the $FreeBSD$ tag. These days jenkins_hash is available in the kernel (see hash(9)) so there's no real need for cxgb to include this file, but I don't touch cxgb except for bug fixes. cxgbe (with the 'e') uses FNV hash from the kernel and so it doesn't have any duplicate hashing implementation. Regards, Navdeep