From owner-svn-src-head@freebsd.org Sat Nov 14 20:57:50 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3DA46465AA0; Sat, 14 Nov 2020 20:57:50 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CYSMy11pwz4R4d; Sat, 14 Nov 2020 20:57:49 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x42a.google.com with SMTP id s8so14153282wrw.10; Sat, 14 Nov 2020 12:57:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EM0MlLnv8yS0eqfznu3lZlFuTOinfp7AJWw/I7B6IM4=; b=ZHcKuXSOkMuSb6L6vm/9bulOkV1ryPKrwhRFqBj5JChfDLGol3s7Itciz0xESZeU0X OYn2RIaReQVUMcZbYvJqnltw2S+4UFDWRBPZvqbjzGxCkl2tPM86WGSy+Uf9SUo9B1mE 4lOYWoV3IZRXo4Czs4M21F7wbI4rBAFbg/T66xBxZLdfNd/q79eDIgeIBcY56Ef4A1i2 Zue2SWykNtHEyidCabWtAq0aQTVkDylvvRayaQHSeu/xTs54m4TnrQT+nWbH7t7E7KeI FpFvJuonNUWg4+DV12yw55MXqvkpTFifhfHF9nlZ2Pi6HQCapWrJYJiFeS1wZIUT0TxT VMsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EM0MlLnv8yS0eqfznu3lZlFuTOinfp7AJWw/I7B6IM4=; b=Lk4gnVMOuALTRhZ2+zMGIWixV2VW0fzdm9+ZwR3ZemT7aF6kJ2ZMhjcqjMTpIHkDvQ dNsD+JU1zCom9g38/nw03TBwScmvIk1N5viWregazAk3Shf0zJcGjTbtbcWmhRKlJGtJ +bFwCRp6vAGvAaLkSVsZWVClhDV7tSN+h7SmkiKNcNxZxjpsEIh/Ic0MCnuNi4Ax9/zW RnbtGoC92TcgKTgU6jkbaazXodke3eQ4K8CWRTwPa2Y7o4WwHl2qHKb6QKErb0Ejn8la morZP0Jz/KrtTxZzRsTQm1Anvds1AnSzmyoT249Swe7VPuO0Pw2OFwg9M5Y9mEqj4ds/ gx/A== X-Gm-Message-State: AOAM531Lq81IDLrAjq4mNhAsm7EMMvIbuCbFRx6R8I5Y3AE+5UudpR13 UTkpZJEHIGItT/46x2azeK1w/uY9BfPbsfDVa5qkxM6rnuA= X-Google-Smtp-Source: ABdhPJwAKu8XMFrirXoTP6P7QvQb9fwl15Yfdp7ffeccdj2il2cYlTqoV60pCg1tGbGjixWhnZVyuQtXG2HH5a2hHuU= X-Received: by 2002:adf:9b98:: with SMTP id d24mr10923504wrc.17.1605387468725; Sat, 14 Nov 2020 12:57:48 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:dec7:0:0:0:0:0 with HTTP; Sat, 14 Nov 2020 12:57:48 -0800 (PST) In-Reply-To: <20201114205355.j2ejnhouipjr6yhk@mutt-hbsd> References: <202011141920.0AEJKbpO050396@repo.freebsd.org> <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> <20201114205355.j2ejnhouipjr6yhk@mutt-hbsd> From: Mateusz Guzik Date: Sat, 14 Nov 2020 21:57:48 +0100 Message-ID: Subject: Re: svn commit: r367692 - head/sys/sys To: Shawn Webb Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CYSMy11pwz4R4d X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2020 20:57:50 -0000 you are expected to recompile all your kernel modules every time you update head On 11/14/20, Shawn Webb wrote: > Are there any kernel modules (in base, in ports, or out-of-both-trees) > that access struct ucred? > > On Sat, Nov 14, 2020 at 09:51:47PM +0100, Mateusz Guzik wrote: >> I don't think so, it does not change any APIs >> >> On 11/14/20, Shawn Webb wrote: >> > On Sat, Nov 14, 2020 at 07:20:37PM +0000, Mateusz Guzik wrote: >> >> Author: mjg >> >> Date: Sat Nov 14 19:20:37 2020 >> >> New Revision: 367692 >> >> URL: https://svnweb.freebsd.org/changeset/base/367692 >> >> >> >> Log: >> >> cred: reorder cr_audit to be closer to the lock >> >> >> >> This makes cr_uid avoid sharing. >> >> >> >> Modified: >> >> head/sys/sys/ucred.h >> >> >> >> Modified: head/sys/sys/ucred.h >> >> ============================================================================== >> >> --- head/sys/sys/ucred.h Sat Nov 14 19:19:27 2020 (r367691) >> >> +++ head/sys/sys/ucred.h Sat Nov 14 19:20:37 2020 (r367692) >> >> @@ -63,6 +63,7 @@ struct ucred { >> >> struct mtx cr_mtx; >> >> u_int cr_ref; /* (c) reference count */ >> >> u_int cr_users; /* (c) proc + thread using this cred */ >> >> + struct auditinfo_addr cr_audit; /* Audit properties. */ >> >> #define cr_startcopy cr_uid >> >> uid_t cr_uid; /* effective user id */ >> >> uid_t cr_ruid; /* real user id */ >> >> @@ -78,7 +79,6 @@ struct ucred { >> >> void *cr_pspare2[2]; /* general use 2 */ >> >> #define cr_endcopy cr_label >> >> struct label *cr_label; /* MAC label */ >> >> - struct auditinfo_addr cr_audit; /* Audit properties. */ >> >> gid_t *cr_groups; /* groups */ >> >> int cr_agroups; /* Available groups */ >> >> gid_t cr_smallgroups[XU_NGROUPS]; /* storage for small groups */ >> > >> > Hey Mateusz, >> > >> > Since this changes KBI, does __FreeBSD_version need bumping? >> > >> > Thanks, >> > >> > -- >> > Shawn Webb >> > Cofounder / Security Engineer >> > HardenedBSD >> > >> > GPG Key ID: 0xFF2E67A277F8E1FA >> > GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 >> > https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc >> > >> >> >> -- >> Mateusz Guzik > > -- > Shawn Webb > Cofounder / Security Engineer > HardenedBSD > > GPG Key ID: 0xFF2E67A277F8E1FA > GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 > https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > -- Mateusz Guzik