From owner-svn-src-head@freebsd.org Fri Mar 13 02:53:14 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D3C3F2724B0 for ; Fri, 13 Mar 2020 02:53:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48dqy10yVdz4HjJ for ; Fri, 13 Mar 2020 02:53:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72a.google.com with SMTP id b5so10142880qkh.8 for ; Thu, 12 Mar 2020 19:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sSQ+RgpjlfGTzzSMgWR7BjeOOR9QQD7Qd9p0GR+sOWo=; b=O9fpNJ6zkWDVehde4oET5gRWWMaD9zVovJfK6n4ySNGdI7LpwdKBxMNPGZeIfXySB0 ENfW/QIdReAmovyZjoLhvG42elsOnrxNXfTdZoBKH0gaQjWGfRei/CZzx3BWVhWrirPd 1lgkXWzCc5sNE/tmUcLkxlkMeVZDT24iPk3H+UT6FLbXsmMboBvW4ZdRY5K2Bzr+gZhD plqggpr1Si1ZTdyU9RcC2ftbTG7BqTmuB0x3RZFXLaFj6isAtwB3BublslX2nfYCtbbd SzeOf1BhEabN9lBxs2dSVuktX1Y12R0xlm5IX3JmzNYCBZfSlY+9W2X8IVOTw4RfwYPk wI5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sSQ+RgpjlfGTzzSMgWR7BjeOOR9QQD7Qd9p0GR+sOWo=; b=gCHF16o4IqcHSeOses3kBxMsZaA/LlTMYSYonDHnXBV04djq3Syk7YeuS8l1+HLEfS e1Yqg7MjmEBnTD26zDaG1Hp6YA/nlwrGFTfUL4Rup/rcTGK0mHnD4grUJYdRfmgSEGx6 SF43yzeXYsKhmziClDRY76Ts5ZNDvoZWkUQuYbdcvMqKeX7TDw6ZQhe6UAcRTMOO3UrO lDoKZwLBEVMMWFi2t84Em68ZmvNnCHxn4XQKTV81ae8TXB0m4CGWgIGNP2Fdgw29B1fW waXgMSPPd/uv5ucrtnHq8SJT9oUhZwN4gucfcCppj8du+U5KoUfa+A5XbzyniJudB+Dl hcQA== X-Gm-Message-State: ANhLgQ29dDqdOubo2EWwrXIGWm/+KEjwfDBGEYGNigC+kYufrq9gOKIZ tu7q3OEN8GZw3k7FtqQyOv5xfl3j+7oqzqY4n/22Oc8t X-Google-Smtp-Source: ADFU+vuVt/e/SfjnSxOZor1tPvPrf3I4fQeejkzk8+jDo1+2VT+uVavRl9jE1JKboSKQY1MZDrz0kyBL8lHrc5Y7AE8= X-Received: by 2002:a37:a746:: with SMTP id q67mr11240653qke.215.1584067991002; Thu, 12 Mar 2020 19:53:11 -0700 (PDT) MIME-Version: 1.0 References: <202003122304.02CN4fXO062077@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 12 Mar 2020 20:52:59 -0600 Message-ID: Subject: Re: svn commit: r358923 - in head: lib/libpmcstat usr.sbin/pmcstat To: Kyle Evans Cc: Ryan Moeller , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 48dqy10yVdz4HjJ X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=O9fpNJ6z; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72a) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.56 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[a.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.56)[ip: (-9.23), ipnet: 2607:f8b0::/32(-1.85), asn: 15169(-1.65), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2020 02:53:14 -0000 On Thu, Mar 12, 2020, 6:35 PM Kyle Evans wrote: > On Thu, Mar 12, 2020 at 6:05 PM Ryan Moeller wrote: > > > > Author: freqlabs > > Date: Thu Mar 12 23:04:40 2020 > > New Revision: 358923 > > URL: https://svnweb.freebsd.org/changeset/base/358923 > > > > Log: > > libpmcstat: Try /boot/modules if module not found > > > > Modules from ports/pkg are commonly installed to /boot/modules rather > than to > > the same directory the kernel resides in. Look there if a module is > not found > > next to the kernel. > > > > Submitted by: mmacy > > Reported by: Nick Principe > > Approved by: mmacy (mentor) > > MFC after: 2 weeks > > Sponsored by: iXsystems, Inc. > > > > It's unclear from the context- is there any particular reason this > can't instead using sysctl kern.module_path and accept a semicolon > delimited list of directories for -k (maybe calling it -k kernelpath > instead)? > There are also #defines for these paths. Warner Thanks, > > Kyle Evans >