From owner-freebsd-perl@FreeBSD.ORG Tue Mar 29 09:44:46 2005 Return-Path: Delivered-To: freebsd-perl@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5E8616A4CE; Tue, 29 Mar 2005 09:44:46 +0000 (GMT) Received: from utopia.leeym.com (utopia.leeym.com [211.21.137.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FB9543D1D; Tue, 29 Mar 2005 09:44:46 +0000 (GMT) (envelope-from leeym@utopia.leeym.com) Received: from localhost (localhost [127.0.0.1]) by utopia.leeym.com (Postfix) with ESMTP id 89B853EA124; Tue, 29 Mar 2005 17:44:45 +0800 (CST) Received: from utopia.leeym.com ([127.0.0.1]) by localhost (utopia.leeym.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45028-05; Tue, 29 Mar 2005 17:44:43 +0800 (CST) Received: by utopia.leeym.com (Postfix, from userid 1000) id C773F3EA0E3; Tue, 29 Mar 2005 17:44:43 +0800 (CST) Date: Tue, 29 Mar 2005 17:44:43 +0800 From: Yen-Ming Lee To: freebsd-gnats-submit@FreeBSD.org, mat@FreeBSD.org, perl@FreeBSD.org Message-ID: <20050329094443.GA53871@utopia.leeym.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TRYliJ5NKNqkz5bu" Content-Disposition: inline X-Fingerprint: FE 7E 04 56 FC D7 24 21 B9 3B 53 06 E8 93 B5 81 X-Public-Key: http://www.leeym.com/pubkey.asc User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at leeym.com Subject: Re: ports/79330: [PATCH] devel/p5-Module-Build: add .packlist in PLIST X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2005 09:44:47 -0000 --TRYliJ5NKNqkz5bu Content-Type: multipart/mixed; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=big5 Content-Disposition: inline On Tue, Mar 29, 2005 at 11:06:51AM +0200, Mathieu Arnold wrote: > I know about that, and I've been thinking on it hard. > > Your PR is just about as inapropriate as possible :-) > > because, if you fix it this way, you'll have to fix every other package > using Module::Build to build, because as it says it, "The default value is > true" meaning that every other port will have this .packlist. The correct > solution is either to use the previous version of the port for 5.4 release > (or to back it out), or to add a create_packlist=false in the appropriate > part of bsd.port.mk. Hmm.... I prefer to set create_packlist in bsd.port.mk BTW, I tried create_packlist=false and it didn't work like what I expected. We should use create_packlist=0 instead. Here comes the patch, and I guess this PR should be assigned to portmgr. -- Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=big5 Content-Disposition: attachment; filename="bsd.port.mk.diff" Index: bsd.port.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v retrieving revision 1.511 diff -u -r1.511 bsd.port.mk --- bsd.port.mk 17 Mar 2005 23:22:07 -0000 1.511 +++ bsd.port.mk 29 Mar 2005 09:36:54 -0000 @@ -1638,6 +1638,7 @@ ALL_TARGET?= PL_BUILD?= Build CONFIGURE_ARGS+= \ + create_packlist=0 \ install_path=lib="${PREFIX}/${SITE_PERL_REL}" \ install_path=arch="${PREFIX}/${SITE_PERL_REL}/${PERL_ARCH}" \ install_path=script="${PREFIX}/bin" \ --+QahgC5+KEYLbs62-- --TRYliJ5NKNqkz5bu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iQCVAwUBQkkji8nMx0NetS5RAQKV0wP+JKC364xlE8DdEZqUHFrqu5u5++MvJMsE Uqo/Z5jHJf6ZRfmk9oq0a2YBxTFgUQ6dsmi5OVSnZWR6j+IXFX71KOChGb+nFkG8 vCu4TW+wCKn3ngTzO4rnooVn9WeMH7KnPKPVRMymZG2GovsROJDXFHD5MXSWXIPy +Kz7OYT11no= =QIBw -----END PGP SIGNATURE----- --TRYliJ5NKNqkz5bu--