From owner-svn-src-head@freebsd.org Mon Sep 23 11:36:17 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8B83FF0F63; Mon, 23 Sep 2019 11:36:17 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46cMhw6Y92z3P67; Mon, 23 Sep 2019 11:36:16 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id CMdYiOF0HIhW9CMdZiji2d; Mon, 23 Sep 2019 05:36:14 -0600 X-Authority-Analysis: v=2.3 cv=FcFJO626 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=D_CeWOJqrPHOpRGt5AEA:9 a=yxUT77K8rovF71sl:21 a=P2dH3RFDTczZq4TR:21 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 6A1935D6; Mon, 23 Sep 2019 04:36:11 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x8NBaA48042190; Mon, 23 Sep 2019 04:36:10 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x8NBaA29042187; Mon, 23 Sep 2019 04:36:10 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201909231136.x8NBaA29042187@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mateusz Guzik cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352617 - head/sys/kern In-reply-to: <201909230853.x8N8rEnu024577@repo.freebsd.org> References: <201909230853.x8N8rEnu024577@repo.freebsd.org> Comments: In-reply-to Mateusz Guzik message dated "Mon, 23 Sep 2019 08:53:14 -0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 23 Sep 2019 04:36:10 -0700 X-CMAE-Envelope: MS4wfNOQj3sg4W4UXcLJDIn/2U9EP5aAGY0mPTJ6q8jzMI3YnPTZDj6tAzmE5ckj2uX3x6G9x85FpgTxkVvzGDQVIlaLJ9ouvWxbQkUIEsRNCZ9GBa268o5k vMHESsKgtt8FtY2wGr6TZizvRyLxIjZ+hPxgsLwUe1jk6i5Jup6qlAqc4C4slVy9Y+FOGiOhkcgzWNUqG2w9bwBUFU7BPVyUPUxCzJnmpBoKrAxU6rVOsWhQ gMGBhWE3yJnHZhD9i3JQY1TDm0UlyPTgLsp7zlE376HPwj6dshDU6qDYgNYnDVGy X-Rspamd-Queue-Id: 46cMhw6Y92z3P67 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Sep 2019 11:36:17 -0000 In message <201909230853.x8N8rEnu024577@repo.freebsd.org>, Mateusz Guzik writes : > Author: mjg > Date: Mon Sep 23 08:53:14 2019 > New Revision: 352617 > URL: https://svnweb.freebsd.org/changeset/base/352617 > > Log: > cache: count evictions of negatve entries Why? > > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/kern/vfs_cache.c > > Modified: head/sys/kern/vfs_cache.c > ============================================================================= > = > --- head/sys/kern/vfs_cache.c Mon Sep 23 07:23:29 2019 (r352616) > +++ head/sys/kern/vfs_cache.c Mon Sep 23 08:53:14 2019 (r352617) > @@ -378,6 +378,8 @@ STATNODE_COUNTER(numfullpathfail2, > "Number of fullpath search errors (VOP_VPTOCNP failures)"); > STATNODE_COUNTER(numfullpathfail4, "Number of fullpath search errors (ENOMEM > )"); > STATNODE_COUNTER(numfullpathfound, "Number of successful fullpath calls"); > +static long numneg_evicted; STATNODE_ULONG(numneg_evicted, > + "Number of negative entries evicted when adding a new entry"); > STATNODE_COUNTER(zap_and_exit_bucket_relock_success, > "Number of successful removals after relocking"); > static long zap_and_exit_bucket_fail; STATNODE_ULONG(zap_and_exit_bucket_fai > l, > @@ -844,6 +846,7 @@ cache_negative_zap_one(void) > ncp->nc_name, ncp->nc_neghits); > > cache_zap_locked(ncp, true); > + numneg_evicted++; > out_unlock_all: > mtx_unlock(&neglist->nl_lock); > rw_wunlock(blp); > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.