From owner-freebsd-ports-bugs@freebsd.org Sun Jan 7 19:30:19 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01738E7C9F5 for ; Sun, 7 Jan 2018 19:30:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB66974C9A for ; Sun, 7 Jan 2018 19:30:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id D0C0A207D7 for ; Sun, 7 Jan 2018 19:30:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w07JUISl083151 for ; Sun, 7 Jan 2018 19:30:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w07JUIX7083150 for freebsd-ports-bugs@FreeBSD.org; Sun, 7 Jan 2018 19:30:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 224977] irc/ircd-hybrid rc script prints error when stopping service Date: Sun, 07 Jan 2018 19:30:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: robertames@hotmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: db@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jan 2018 19:30:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224977 Bug ID: 224977 Summary: irc/ircd-hybrid rc script prints error when stopping service Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: db@FreeBSD.org Reporter: robertames@hotmail.com Assignee: db@FreeBSD.org Flags: maintainer-feedback?(db@FreeBSD.org) When shutting down ircd-hybrid, a confusing error is displayed stating the pid file does not exist: # /usr/local/etc/rc.d/ircd-hybrid stop Stopping ircd_hybrid. Waiting for PIDS: 14504. rm: /var/run/ircd/ircd.pid: No such file or directory This is because after ircd correctly cleans up it's pid file, the rc script tries to delete the non existing file. In the rc script, stop_postcmd is not needed. Patch: --- irc/ircd-hybrid/files/ircd-hybrid.in.orig 2017-09-28 19:21:57.0000000= 00 -0500 +++ irc/ircd-hybrid/files/ircd-hybrid.in 2018-01-06 09:16:04.3543860= 00 -0600 @@ -19,7 +19,6 @@ command=3D/usr/local/bin/ircd start_precmd=3Dpid_touch -stop_postcmd=3Dpid_rm load_rc_config ${name} @@ -36,9 +35,4 @@ chown $ircd_hybrid_user $pidfile } -pid_rm () -{ - rm $pidfile -} - run_rc_command "$1" If stop_postcmd is needed for some reason I don't understand, then the "rm" command should be "rm -f" so no error is displayed. --=20 You are receiving this mail because: You are the assignee for the bug.=