From owner-freebsd-bugs@FreeBSD.ORG Fri Feb 12 16:00:18 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1A9D1065730 for ; Fri, 12 Feb 2010 16:00:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8F3378FC18 for ; Fri, 12 Feb 2010 16:00:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o1CG0IIX090349 for ; Fri, 12 Feb 2010 16:00:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o1CG0ICv090348; Fri, 12 Feb 2010 16:00:18 GMT (envelope-from gnats) Date: Fri, 12 Feb 2010 16:00:18 GMT Message-Id: <201002121600.o1CG0ICv090348@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: pluknet Cc: Subject: Re: misc/143807: pthread_create retval check fixup X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pluknet List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2010 16:00:18 -0000 The following reply was made to PR misc/143807; it has been noted by GNATS. From: pluknet To: Ruslan Ermilov Cc: bug-followup@freebsd.org Subject: Re: misc/143807: pthread_create retval check fixup Date: Fri, 12 Feb 2010 18:53:33 +0300 On 12 February 2010 18:22, Ruslan Ermilov wrote: > On Thu, Feb 11, 2010 at 04:53:14PM +0000, pluknet wrote: >> I faced with incorrect return code checking in netrate's pthread_create(3) >> calls: pthread_create may return errcode > 0, while in netrate/ code >> pthread_create() checked for < 0 on error. > > The scope of the problem isn't limited just to pthread_create(). > In fact, it seems to be a common problem (I only scanned > src/tools/): Yep, that's what I came with later in PR. Just tried to not affect too much at one step. -- wbr, pluknet