From owner-svn-src-all@FreeBSD.ORG Sat May 14 11:24:29 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58C4A106564A; Sat, 14 May 2011 11:24:29 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4F4618FC15; Sat, 14 May 2011 11:24:27 +0000 (UTC) Received: by bwz12 with SMTP id 12so3948287bwz.13 for ; Sat, 14 May 2011 04:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:x-comment-to :sender:date:in-reply-to:message-id:user-agent:mime-version :content-type; bh=iWh/GLCvtaLcRpYhJO/W6ycKXcWozsGPWlsOYfBf37c=; b=nbQoBwtXhxlpTCs3GbUtCoaN1iwFXXmzzKvwVASZTzDQsZGmxGGElzEzbUaHcK2bf+ U8hvj577REcPM0XbCR17lE7Leyfk3ceEmBGe5wazSDc/1C9/GOgbwzPWIbXRCi8DfF1+ KeSGTOE7Zus5gYl107WhEcuAbkUy7f23A+9iY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=C2JDlxk7/TANxm0pj8DobpZiylx8CdbP86vughC7MeDa8xOcIGheWDRZ167CU1O47h KVga53IdHJ9F7UQxvjyW0kjfBXLzRrgFTQCUln+WuJ09qEyc6/EMlnK+j19t+9JB7+Ml LetM8LMttzsbd+0vEHVCS1Y3aQFcvoibGvPFU= Received: by 10.204.7.74 with SMTP id c10mr2418994bkc.104.1305372267042; Sat, 14 May 2011 04:24:27 -0700 (PDT) Received: from localhost ([95.69.172.154]) by mx.google.com with ESMTPS id l1sm1869422bkl.13.2011.05.14.04.24.24 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 14 May 2011 04:24:25 -0700 (PDT) From: Mikolaj Golub To: John Baldwin References: <201105022105.p42L5q3j054498@svn.freebsd.org> <86pqnlbmao.fsf@kopusha.home.net> X-Comment-To: Mikolaj Golub Sender: Mikolaj Golub Date: Sat, 14 May 2011 14:24:23 +0300 In-Reply-To: <86pqnlbmao.fsf@kopusha.home.net> (Mikolaj Golub's message of "Sat, 14 May 2011 13:37:19 +0300") Message-ID: <86liy9bk48.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221346 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 May 2011 11:24:29 -0000 On Sat, 14 May 2011 13:37:19 +0300 Mikolaj Golub wrote to John Baldwin: JB>> + KASSERT(SEQ_GEQ(tp->rcv_adv, tp->rcv_nxt), JB>> + ("tcp_input negative window: tp %p rcv_nxt %u rcv_adv %u", tp, JB>> + tp->rcv_adv, tp->rcv_nxt)); BTW, the message is printed wrongly because of the wrong order of arguments. It was a bit confusing :) JB>> Modified: head/sys/netinet/tcp_timewait.c JB>> ============================================================================== JB>> --- head/sys/netinet/tcp_timewait.c Mon May 2 21:04:37 2011 (r221345) JB>> +++ head/sys/netinet/tcp_timewait.c Mon May 2 21:05:52 2011 (r221346) JB>> @@ -242,6 +242,9 @@ tcp_twstart(struct tcpcb *tp) JB>> /* JB>> * Recover last window size sent. JB>> */ JB>> + KASSERT(SEQ_GEQ(tp->rcv_adv, tp->rcv_nxt), JB>> + ("tcp_twstart negative window: tp %p rcv_nxt %u rcv_adv %u", tp, JB>> + tp->rcv_adv, tp->rcv_nxt)); The same here. JB>> tw->last_win = (tp->rcv_adv - tp->rcv_nxt) >> tp->rcv_scale; JB>> JB>> /* MG> -- MG> Mikolaj Golub -- Mikolaj Golub