Date: Sat, 14 May 2011 14:24:23 +0300 From: Mikolaj Golub <trociny@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221346 - head/sys/netinet Message-ID: <86liy9bk48.fsf@kopusha.home.net> In-Reply-To: <86pqnlbmao.fsf@kopusha.home.net> (Mikolaj Golub's message of "Sat, 14 May 2011 13:37:19 %2B0300") References: <201105022105.p42L5q3j054498@svn.freebsd.org> <86pqnlbmao.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 14 May 2011 13:37:19 +0300 Mikolaj Golub wrote to John Baldwin:
JB>> + KASSERT(SEQ_GEQ(tp->rcv_adv, tp->rcv_nxt),
JB>> + ("tcp_input negative window: tp %p rcv_nxt %u rcv_adv %u", tp,
JB>> + tp->rcv_adv, tp->rcv_nxt));
BTW, the message is printed wrongly because of the wrong order of arguments. It
was a bit confusing :)
JB>> Modified: head/sys/netinet/tcp_timewait.c
JB>> ==============================================================================
JB>> --- head/sys/netinet/tcp_timewait.c Mon May 2 21:04:37 2011 (r221345)
JB>> +++ head/sys/netinet/tcp_timewait.c Mon May 2 21:05:52 2011 (r221346)
JB>> @@ -242,6 +242,9 @@ tcp_twstart(struct tcpcb *tp)
JB>> /*
JB>> * Recover last window size sent.
JB>> */
JB>> + KASSERT(SEQ_GEQ(tp->rcv_adv, tp->rcv_nxt),
JB>> + ("tcp_twstart negative window: tp %p rcv_nxt %u rcv_adv %u", tp,
JB>> + tp->rcv_adv, tp->rcv_nxt));
The same here.
JB>> tw->last_win = (tp->rcv_adv - tp->rcv_nxt) >> tp->rcv_scale;
JB>>
JB>> /*
MG> --
MG> Mikolaj Golub
--
Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86liy9bk48.fsf>