From owner-svn-src-all@freebsd.org Fri Feb 28 01:27:21 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 66767255BB5; Fri, 28 Feb 2020 01:27:21 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TBjN6NFGz3L6h; Fri, 28 Feb 2020 01:27:20 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-ot1-x32c.google.com with SMTP id a36so1129223otb.7; Thu, 27 Feb 2020 17:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RMy8NnAxBkXpJi+8Zo0z2vV42C3w9rQaAFyltfhXYH4=; b=Zs+x3BbWNwiw3mw2KjQQrnnOSp/8Wz5agfzku2on2OlHBwgJ26dW+9Xb+WqYpiSJ4q mAggKAWix7KIBeqrTFo7JOgUk1K+xbBdcBFmw36MOHnQVAswTUpYwEwrgz58oaowEgne jycxZIbGBb/wi0BCh2TYW22GNMNkbvpiO6rvAylU9XdYLHAbBf6tR8wSURhyTWx+PsQH Mml2MJ+gT9rlyoYAcJgmTHluZFQAiXWEQQ7ca4jeZSICk/mfjdWp8ghLx+xgayffXHY7 2AQzhtB4y0HY4yR64gu4jccnDImnwxkLt+73XBXOfvwzvMrHwA4VWwliEMI7ROZeph8X FniQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RMy8NnAxBkXpJi+8Zo0z2vV42C3w9rQaAFyltfhXYH4=; b=hdGVC++tKl2LnXcDstZJsXVWYkHBi2gxYNmOUGRvRsAietEg8YJKAtwZSImMEMCe+t DD1koEjHP4MiESgLGgt/l3RflA4mlZNY3Cq2bLSRN+xk6X7jbdxjlshHZ30KK5stFsIl DrRkFCji86SrYfPzek2AsjhBruUQOxoJ3AxKYrP7x1WhGTPwdpf/JPiISBejTXjY29YW ZkTYt/gJLUVDHLtJyO//D/dJrYej1ku3dw6iyBsyb9WPNaU+N+H87kytvykMUiSrdVcX UxwIFdCyC4/AwguDVB8dFjlCPq2tIIB7mtFtucfSKQ50LwXIh17HC3qD/XrXwhKK3Q5G 38Gg== X-Gm-Message-State: APjAAAXq/kErwXlNWmc+oXRyPtwaXgFQlCDG/x4m5EH4KN/Yt2m0DAvs Zw+HfIXbJKGmiJQut6s9F2YiPcOE59Xv8Kzhj+l/w/lW X-Google-Smtp-Source: APXvYqyOXENHhdEWRSWO8FdXTS8OXq34LTfonDaXM3sGdBmCoqnDQytc1a+uFxXVoQ+dZg6hNSCz/nOE8/uDcB7/39s= X-Received: by 2002:a05:6830:22d8:: with SMTP id q24mr1494754otc.0.1582853238857; Thu, 27 Feb 2020 17:27:18 -0800 (PST) MIME-Version: 1.0 References: <202002280118.01S1IBRl044620@repo.freebsd.org> In-Reply-To: <202002280118.01S1IBRl044620@repo.freebsd.org> From: Benjamin Kaduk Date: Thu, 27 Feb 2020 17:27:08 -0800 Message-ID: Subject: Re: svn commit: r358417 - head/sys/cam To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 48TBjN6NFGz3L6h X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 01:27:21 -0000 On Thu, Feb 27, 2020 at 5:18 PM Warner Losh wrote: > Author: imp > Date: Fri Feb 28 01:18:11 2020 > New Revision: 358417 > URL: https://svnweb.freebsd.org/changeset/base/358417 > > Log: > This is a FALLTHROUGH for sure. no need for xxx comment. > > Modified: > head/sys/cam/cam_xpt.c > > Modified: head/sys/cam/cam_xpt.c > > ============================================================================== > --- head/sys/cam/cam_xpt.c Fri Feb 28 01:02:01 2020 (r358416) > +++ head/sys/cam/cam_xpt.c Fri Feb 28 01:18:11 2020 (r358417) > @@ -2690,7 +2690,7 @@ xpt_action_default(union ccb *start_ccb) > case XPT_NVME_ADMIN: > /* FALLTHROUGH */ > case XPT_MMC_IO: > - /* XXX just like nmve_io? */ > + /* FALLTHROUGH */ > case XPT_RESET_DEV: > case XPT_ENG_EXEC: > case XPT_SMP_IO: > > Okay, I'll bite. Why do XPT_NVME_ADMIN and XPT_MMC_IO get "FALLTHROUGH" comments but XPT_RESET_DEV and XPT_ENG_EXEC just get listed as part of the same grouping as XPT_SMP_IO? -Ben