Date: Wed, 18 Nov 2020 15:37:36 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367695 - in head/sys: kern sys Message-ID: <4f6f6b0a-e71c-a286-507e-abf2522c142c@FreeBSD.org> In-Reply-To: <CAGudoHGyyJRRmEUuoVkjowO5kRLpVz_VFha3MQwu%2B1P_4MU1kg@mail.gmail.com> References: <202011141922.0AEJM2ld055995@repo.freebsd.org> <d3624785-1bc4-43d1-37b6-12a989444505@FreeBSD.org> <CAGudoHGyyJRRmEUuoVkjowO5kRLpVz_VFha3MQwu%2B1P_4MU1kg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/18/20 2:16 PM, Mateusz Guzik wrote: > On 11/17/20, John Baldwin <jhb@freebsd.org> wrote: >> On 11/14/20 11:22 AM, Mateusz Guzik wrote: > Interested parties can check the consumer (also seen in the diff) to > see this is for consistency. I don't think any comments are warranted > in the header. I did read the consumer, and there didn't seem tremendous value in the extra line there. >> These changes would benefit from review. >> > > I don't think it's feasible to ask for review for everything lest it > degardes to rubber stamping and I don't think this change warranted > it, regardless of the cosmetic issues which can always show up. That is not consistent with the direction the project is moving. If you check the commit logs of other high-volume committers such as markj@, kib@, or myself, you will find that a substantial number of those commits are reviewed (typically in phabricator) without preventing us from making useful progress. Also, while the previous core did not mandate reviews, we moved closer to it when the Pre-Commit Review chapter was added to the Committer's Guide: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/pre-commit-review.html In the related thread on developers@ we indicated that while weren't yet making pre-commit review mandatory, we collectively want to move in that direction. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4f6f6b0a-e71c-a286-507e-abf2522c142c>