From owner-cvs-ports@FreeBSD.ORG Fri Jan 23 16:40:25 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7CD616A4CE; Fri, 23 Jan 2004 16:40:25 -0800 (PST) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DC1943D4C; Fri, 23 Jan 2004 16:40:24 -0800 (PST) (envelope-from eischen@vigrid.com) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mail.pcnet.com (8.12.10/8.12.1) with ESMTP id i0O0eNiw019218; Fri, 23 Jan 2004 19:40:23 -0500 (EST) Date: Fri, 23 Jan 2004 19:40:23 -0500 (EST) From: Daniel Eischen X-Sender: eischen@pcnet5.pcnet.com To: Adam Weinberger In-Reply-To: <20040124003456.GV3365@toxic.magnesium.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2004 00:40:25 -0000 On 23 Jan 2004, Adam Weinberger wrote: > >> (01.23.2004 @ 1930 PST): Daniel Eischen said, in 0.7K: << > > On 23 Jan 2004, Adam Weinberger wrote: > > > > > >> (01.23.2004 @ 1731 PST): Daniel Eischen said, in 0.3K: << > > > > deischen 2004/01/23 14:31:36 PST > > > > > > > > FreeBSD ports repository > > > > > > > > Modified files: > > > > Mk bsd.port.mk > > > > Log: > > > > Make PTHREAD_LIBS and PTHREAD_CFLAGS conditional. Also remove > > > > -D_THREAD_SAFE from PTHREAD_CFLAGS when it isn't needed. > > > > > > > > Revision Changes Path > > > > 1.482 +3 -3 ports/Mk/bsd.port.mk > > > >> end of "cvs commit: ports/Mk bsd.port.mk" from Daniel Eischen << > > > > > > Was this change approved by portmgr? > > > > Not explicity, but portmgr is well aware of what's going on > > (hint: s/-lc_r/-lpthread). > >> end of "Re: cvs commit: ports/Mk bsd.port.mk" from Daniel Eischen << > > I was going to make a comment about not recalling any messages to > portmgr@ about this, but I think it's a case of seeing something so much > that you cease to see it anymore. ::P Well, I admit I'm at fault here. I didn't notice the big friggin' notice at the beginning of the file: # DO NOT COMMIT CHANGES TO THIS FILE BY YOURSELF, EVEN IF YOU DID NOT GET # A RESPONSE FROM THE MAINTAINER(S) WITHIN A REASONABLE TIMEFRAME! ALL # UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED! portmgr has been CC'd in all our email, but I never explicitly asked for permission to do this specific change. If you want, I can back it out. -- Dan EischenA