From owner-svn-src-projects@FreeBSD.ORG Thu Dec 23 09:47:09 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 903511065672; Thu, 23 Dec 2010 09:47:09 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 2F69D8FC1B; Thu, 23 Dec 2010 09:47:08 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 218E945C8A; Thu, 23 Dec 2010 10:19:48 +0100 (CET) Received: from localhost (89-73-192-49.dynamic.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 79B9845685; Thu, 23 Dec 2010 10:19:42 +0100 (CET) Date: Thu, 23 Dec 2010 10:19:39 +0100 From: Pawel Jakub Dawidek To: Alexander Motin Message-ID: <20101223091939.GB43446@garage.freebsd.pl> References: <201012220902.oBM92MpZ098772@svn.freebsd.org> <20101223090812.GA43446@garage.freebsd.pl> <4D13129D.3080606@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: <4D13129D.3080606@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216649 - projects/graid/head/sys/geom/raid X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Dec 2010 09:47:09 -0000 --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 23, 2010 at 11:13:01AM +0200, Alexander Motin wrote: > Pawel Jakub Dawidek wrote: > > On Wed, Dec 22, 2010 at 09:02:22AM +0000, Alexander Motin wrote: > >> Author: mav > >> Date: Wed Dec 22 09:02:22 2010 > >> New Revision: 216649 > >> URL: http://svn.freebsd.org/changeset/base/216649 > >> > >> Log: > >> Implement basic metadata generation check. To be sure that used meta= data is > >> up to date - delay volumes creation until we have all disks or timeo= ut > >> expires. This probably obsolete same functionality done at volumes l= evel. > > [...] > >> +static struct intel_raid_conf * > >> +intel_meta_copy(struct intel_raid_conf *meta) > >> +{ > >> + struct intel_raid_conf *nmeta; > >> + > >> + nmeta =3D malloc(meta->config_size, M_MD_INTEL, M_WAITOK | M_ZERO); > >> + memcpy(nmeta, meta, meta->config_size); > >> + return (nmeta); > >> +} > >=20 > > The M_ZERO flag seems to be redundant, as you fill the entire buffer in > > the next line. >=20 > Indeed. Thanks. But I am sure it is not the biggest of my problems. :) :) If you have any GEOM-related questions, don't hesitate to ask. When you'll have a version that is ready for a full review, let me know and I'll try to find some time to do it. Is your class going to be generally usable or you just want to support those pseudo-hardware RAIDs? If the former and you're planning to eventually relace gmirror/gstripe/gconcat with it, would be also nice to keep RAID3 support. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk0TFCsACgkQForvXbEpPzR+2gCfVZh7qg5BoAyMN4dFSR24H4s7 jSMAn1pgB+QI6M3N4dERM8Ocmd2xDVY5 =FLlP -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA--