From nobody Mon Mar 10 18:15:52 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZBQ7G28BZz5pRw5; Mon, 10 Mar 2025 18:15:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZBQ7F6y8kz3pWY; Mon, 10 Mar 2025 18:15:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741630554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ahwZQuQSdwmwvvQUSwWrAAyw+W36t0V+shzZw8DAxQ=; b=LRBHfdA8TARhN/2GFQ54VC5fGk2sE52FOatD0pvdYQrIRjwjcRb1Fd1eg/pfo73aztkcav 4hlnT4dm8V7atAkeLFtPjm1+0CyDtLLPJmqjFY/Xl4WXipf9XKZBxPx1qyg36SC2wSyiQa bD0zFbsiEktwcqZBDx0TlGUaQ3C2RBO0G5Lpa8vVGhhWp8/Mi9huIQt3rHAY12mBrCihkr rrrgjKNyLrcElj+ySwOpfiUXInq+9p1FWKYZWFColPeF6isB3bxbwAMv4G+LPs4pCUL/fj gbkIZAbzJU9HLFGT9DYmpIZPwOjXeqWEoodX+bT974MXVG4bAuWwLROKo6q9sg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741630554; a=rsa-sha256; cv=none; b=mImTvy3avUU3fPjbNeBiyd0LrJqPYlJGOEBpT+TdLonzed0P7baBMcUVNidxQV0HbuxwV0 6aDPvCxr41YG8M0rK+wNgrj+O+LLGvSFTSWxKFwJHaAHIJm13OtwH85NTsEWUHJsY0IqaW HlVp/nB1ReY+6uC6aHttO0jVRj4cAkcd85ASEeMiRI3ERxTayjKK9BPvlxTiWXEVsnpiE9 aTrsart5ADcHe+3lkM7xAewsVdA1sYqhWUomtnAQUXtC2Hh/DcXtAL5fpVZRorO5o2S0Nt ovsf8wWX4oBimNAHcbAdCD9PMdGNXUzKOfD/B+ILTAuh81ax/7wJIgJnMPj3Cg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741630554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ahwZQuQSdwmwvvQUSwWrAAyw+W36t0V+shzZw8DAxQ=; b=vb5AuOFoltt10feNpsN03zJVaHQdG57v/ySrEM9NzBe7MIEmQNzqRksPDdLT4YrV9CyMTn Tx2vNd8hZIiUOEfIe3Tqq+WyriaxdT3uSqurOGNsFCqdONNm+o7Np7teZZz+lDPyQv6Yr2 T0Df9YiAGXnXUjYowDe5pw1mdnGLmfIQvGk0Qfj2qilnQdW2B9yuKAEJq2haSxLU7eG22w 4CABqliOhlmtW2wOc7VeEecyoQwHqhEVKtMD1w3lfTaesVAO5gH4N9pfr3x+iizcekyl1Y KRVBZEAICVyBn1UqvbkmulI4EcJ4+XOODR7Ni1prSyU+4W9MZvdJ19Ev8IhB/A== Received: from [IPV6:2601:5c0:4200:b830:d4cf:e78:681a:fd62] (unknown [IPv6:2601:5c0:4200:b830:d4cf:e78:681a:fd62]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZBQ7F4l4tz1Bd2; Mon, 10 Mar 2025 18:15:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3ffc904b-7a14-412e-bf08-4703b00e3ffb@FreeBSD.org> Date: Mon, 10 Mar 2025 14:15:52 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK Content-Language: en-US To: Ravi Pokala , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202503101735.52AHZiu6027210@gitrepo.freebsd.org> <14C8991D-C686-48DC-9E5D-5F40CE1C75BB@panasas.com> From: John Baldwin In-Reply-To: <14C8991D-C686-48DC-9E5D-5F40CE1C75BB@panasas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/10/25 13:41, Ravi Pokala wrote: > Hi John, > >> This reverts commit 234683726708cf5212d672d676d30056d4133859. > > The commit message for that change says that this allocation might be done while holding a lock, and so M_WAITOK is not valid. So then why is this change okay? > > Thanks, Because the earlier commit to sdhci in this same push fixed it to create devices in a sleepable context. -- John Baldwin