From owner-freebsd-arch@FreeBSD.ORG Thu Feb 25 15:09:18 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 628B6106566C for ; Thu, 25 Feb 2010 15:09:18 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-iw0-f185.google.com (mail-iw0-f185.google.com [209.85.223.185]) by mx1.freebsd.org (Postfix) with ESMTP id 240178FC21 for ; Thu, 25 Feb 2010 15:09:17 +0000 (UTC) Received: by iwn15 with SMTP id 15so5166856iwn.7 for ; Thu, 25 Feb 2010 07:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=h8MDpA10idA5j3w8vNeOZKJy8nI2MPVpRf+juovL1lE=; b=X0iMly/VVn8S28Pw2MSqSSqLsTw/NUIz1fXknvGEiwDpgPXGI+r5LgCrNh6DTaYqOf VbrP0RDiQMtdBqU1w54eButToFoaP4DUQapKhrL1cLOy5Jv8AWNc/fbuuTgOxHSRwYOg dQVKY3YewG07ItPhAgO1mymMmjlhe1gvRW72k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=rKBicXzVRXfJpOP4uMCZV/ZzVKb2gJAGQfblMYpejnlqmlCizzYO/2h7Gyfo5jRuJN CBeFJOWAk7gy+x8rSkLeFAUOSic09DAoLzOpjQDqzthukSVw0bJx/8HW3jD2i+7DCKQ8 xrMq2fZCWGJXbwbF4nBlY/ctfiqr89oQEMdSY= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.190.137 with SMTP id di9mr113926ibb.76.1267110528887; Thu, 25 Feb 2010 07:08:48 -0800 (PST) In-Reply-To: <3bbf2fe11002250533i2fe71007l9b003abb277aa22a@mail.gmail.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216195440.GF50403@deviant.kiev.zoral.com.ua> <3bbf2fe11002240718x5182aa93w5a00c657a0fba5f6@mail.gmail.com> <20100224.210808.634347869559333650.imp@bsdimp.com> <3bbf2fe11002250533i2fe71007l9b003abb277aa22a@mail.gmail.com> Date: Thu, 25 Feb 2010 16:08:48 +0100 X-Google-Sender-Auth: 39e6a66214c6332d Message-ID: <3bbf2fe11002250708i1f36174am474e6f7ee4111e63@mail.gmail.com> From: Attilio Rao To: "M. Warner Losh" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: kostikbel@gmail.com, arch@freebsd.org, emaste@sandvine.com Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2010 15:09:18 -0000 2010/2/25 Attilio Rao : > 2010/2/25 M. Warner Losh : >> In message: <3bbf2fe11002240718x5182aa93w5a00c657a0fba5f6@mail.gmail.com= > >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Attilio Rao writes: >> : 2010/2/16 Kostik Belousov : >> : > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: >> : >> The following patch: >> : >> http://www.freebsd.org/~attilio/x86.diff >> : >> >> : >> starts the effort for having a shared sub-tree between amd64 and ia= 32. >> : >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> : >> and what my customer was more interested in (isa/*) in order to >> : >> kick-off the effort and, in the future, move gradually the code the= re. >> : >> With the machine/isa/* cleanup about 10 files are trimmed and I'm s= ure >> : >> more can be achieved easilly. >> : >> There are few things to discuss. One, that I had not necessity to d= ig >> : >> about still, is about how to organize headers (include/). Maybe som= e >> : >> replication ala pc98 may be good. >> : >> >> : >> The patch is big but it is mostly added and removed files (look at = the >> : >> files.X in order to understand better how files movements happened)= . >> : >> >> : >> Hope to see comments and reviews. >> : > >> : > IMO the diff is unreadable. I suggest to do actual svn cp (not svn m= v) >> : > operation now, without a review, and post a diff that should be appl= ied >> : > to x86/ directory, as well as to build glue. >> : >> : I think that this patch juices out all the relevant part without noise= : >> : http://www.freebsd.org/~attilio/x86-2.diff >> >> Looks like you didn't add the required "sys/x86" files to files.pc98. > > There is still no-use for powerpc as it uses its own "isa" > implementation it seems (it should be cbus). s/powerpc/pc98, sorry. Attilio --=20 Peace can only be achieved by understanding - A. Einstein