From owner-dev-commits-src-main@freebsd.org Fri Feb 26 22:57:23 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61224551F86; Fri, 26 Feb 2021 22:57:23 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnQ5v10TDz3H0x; Fri, 26 Feb 2021 22:57:22 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 11QMvJ0u032240; Fri, 26 Feb 2021 14:57:19 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 11QMvJsL032239; Fri, 26 Feb 2021 14:57:19 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202102262257.11QMvJsL032239@gndrsh.dnsmgr.net> Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database In-Reply-To: <44c9cd7b-e032-4613-81be-6214f37d2fbe@FreeBSD.org> To: Baptiste Daroussin Date: Fri, 26 Feb 2021 14:57:19 -0800 (PST) CC: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4DnQ5v10TDz3H0x X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 22:57:23 -0000 > > 26 f?vr. 2021 22:41:37 Enji Cooper : > > > > >> On Feb 25, 2021, at 5:27 AM, Baptiste Daroussin wrote: > >> > >> The branch main has been updated by bapt: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=2a50a9de8340f08bd876e9e5993332ae14376f80 > >> > >> commit 2a50a9de8340f08bd876e9e5993332ae14376f80 > >> Author:???? Baptiste Daroussin > >> AuthorDate: 2021-02-23 16:17:32 +0000 > >> Commit:???? Baptiste Daroussin > >> CommitDate: 2021-02-25 13:25:32 +0000 > >> > >> ?? terminfo: add terminfo database > >> > >> ?? Tested by:????? manu, jbeich > > > > Hi Baptiste, > > ? A question and a comment: > > ? 1. Was this reviewed in Phabricator? > > ? 2. The details on why the terminfo database is being added are a bit lean too to non-Unix users. It would be nice if the motivation for the change was documented in the commit message. > > Thanks! > > -Enji > > No it was not reviewed in phabricator as it does not really bring any code, but it was discussed on the mailing lists with a heads up on the plan and the motivation, and all the reaction were in favor of this change. On what mailing list as I do not recall such a thread, which means I probably need to add yet another list. > Note thay while it could have been better written this commit is the third of a serie, where the first one explain a bit more things. > > Bapt -- Rod Grimes rgrimes@freebsd.org