From owner-svn-ports-head@FreeBSD.ORG Mon Feb 10 10:12:50 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A97413B2; Mon, 10 Feb 2014 10:12:50 +0000 (UTC) Received: from mail-wg0-x22b.google.com (mail-wg0-x22b.google.com [IPv6:2a00:1450:400c:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5244B1AA9; Mon, 10 Feb 2014 10:12:49 +0000 (UTC) Received: by mail-wg0-f43.google.com with SMTP id y10so3933216wgg.34 for ; Mon, 10 Feb 2014 02:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Duz1iDxnIfxyEztiq+KiKzSOM3DNHv0JTrIdYz1lRSU=; b=ropXYnINazSaIzyIT5l0/a/Ip9WJoLMTkt3b1gxs2Tmmp/WlWX1c0IlyPtvvR/yyCD 6LINcusyiOp2buXk+w+eYY+NiooebdSPdS6Ewk8fj2hhktrZwzYIHBRQcLKbofefmdI7 Y/A/1roe5HtICEXP7rqFf3uAhio7nl6ya5ldrScJmbKZgk59SEcguIUYepSszdjb7ZTE KhoxTLg9UWZ3KYtt48SFJDCAVQ6Wsk3lyQT8adCdO3Ej+mnE9E75pm3nN+zs7bLs8RYZ cZI+iizUpujRvDgf+fNiDksj1uL7AUislv+DvFyqy6xAtUHZ6IxcJpKgKe8W+R4jq3K4 gZsA== X-Received: by 10.180.77.200 with SMTP id u8mr9907121wiw.48.1392027167574; Mon, 10 Feb 2014 02:12:47 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id pm2sm37321019wic.0.2014.02.10.02.12.45 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 10 Feb 2014 02:12:46 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 10 Feb 2014 11:12:44 +0100 From: Baptiste Daroussin To: David Chisnall Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <20140210101243.GX80056@ithaqua.etoilebsd.net> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> <20140210075232.GU80056@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0k4Rxg87Lb8yV0u3" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, Steve Wills , svn-ports-all@FreeBSD.org, John Marino , ports-committers@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2014 10:12:50 -0000 --0k4Rxg87Lb8yV0u3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2014 at 09:47:17AM +0000, David Chisnall wrote: > On 10 Feb 2014, at 07:52, Baptiste Daroussin wrote: >=20 > > I do not think that requires an approval, as for FreeBSD this change is= no-op, > > It is also no intrusive and just "fixes" building of that port for Drag= onfly. >=20 > Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale. Alr= eady we have problems with convoluted OSVERSION expressions that are hard t= o understand and really mean 'fix for PR12345 has been merged to the releva= nt branch'. It would be far better to centralise these into a single file = for each platform, listing features / bugfixes / needed work-arounds and st= art removing explicit OSVERSION checks from any other Makefiles. If suppor= ting Dragonfly is one of our objectives, then I'd strongly encourage the pe= ople who are working on it to engage in this kind of cleanup, rather than p= iling more hacks into the tree. >=20 > David >=20 If one has a nice idea to centralize those informations I'm all about it, by nice idea I mean format and implementation. May that be OPSYS and/or OSVERSION both requires loading too many times bsd= =2E*.mk which is not good, looking forward for propositions. regards, Bapt --0k4Rxg87Lb8yV0u3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlL4phsACgkQ8kTtMUmk6EzMnACgu8yiX3vX+z8wwj0/+vVwK7dK yGAAnAxrLGsOhbdLjFb9JJSL4cpKQtfr =x4Qw -----END PGP SIGNATURE----- --0k4Rxg87Lb8yV0u3--