Date: Wed, 22 Aug 2012 09:11:15 -0700 From: Jason Evans <jasone@freebsd.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jan Beich <jbeich@tormail.org> Subject: Re: jemalloc and clang (was: Re: svn commit: r239462 - in head) Message-ID: <64C5CE7C-1AB5-4F19-A261-5A166470A12D@freebsd.org> In-Reply-To: <50334957.6020201@FreeBSD.org> References: <201208201833.q7KIX58p075876@svn.freebsd.org> <1T3c9K-000Jlb-7g@internal.tormail.org> <50334957.6020201@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 21, 2012, at 1:39 AM, Dimitry Andric <dim@FreeBSD.org> wrote: > On 2012-08-21 02:17, Jan Beich wrote: > ... >> Time to revert r228540? >> >> Index: contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h >> =================================================================== >> --- contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h (revision 239467) >> +++ contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h (working copy) >> @@ -56,10 +56,6 @@ >> #ifndef JEMALLOC_TLS_MODEL >> # define JEMALLOC_TLS_MODEL /* Default. */ >> #endif >> -#ifdef __clang__ >> -# undef JEMALLOC_TLS_MODEL >> -# define JEMALLOC_TLS_MODEL /* clang does not support tls_model yet. */ >> -#endif >> >> #define STATIC_PAGE_SHIFT PAGE_SHIFT >> #define LG_SIZEOF_INT 2 > > Well, if Jason would like to support upstream jemalloc for different > versions of clang, it is probably better to to use __has_feature() > instead. > > Jason, what do you think of the attached patch? Or could we just remove > the whole #ifdef __clang__ part? > <jemalloc-clang-tlsmodel-1.diff> I'm happy with the above patch (completely removing the #ifdef __clang__). Jason
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?64C5CE7C-1AB5-4F19-A261-5A166470A12D>