From owner-freebsd-hackers@FreeBSD.ORG Thu Nov 14 16:21:07 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8D6F3862; Thu, 14 Nov 2013 16:21:07 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 52BAE2853; Thu, 14 Nov 2013 16:21:07 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.15]) by ltcfislmsgpa03.fnfis.com (8.14.5/8.14.5) with ESMTP id rAEGL6k0018358 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 14 Nov 2013 10:21:06 -0600 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.152]) by LTCFISWMSGHT04.FNFIS.com ([10.132.206.15]) with mapi id 14.03.0158.001; Thu, 14 Nov 2013 10:21:04 -0600 From: "Teske, Devin" To: Jordan Hubbard Subject: Re: Loader forth changes for customization Thread-Topic: Loader forth changes for customization Thread-Index: AQHO4EjnMi0GIoZQO0eCkJ5RnRP0C5olTwmA Date: Thu, 14 Nov 2013 16:21:04 +0000 Message-ID: <7DD09B24-F4D7-4ED4-83E2-E9D72C157020@fisglobal.com> References: <5282E56F.4020307@freebsd.org> <52832003.8080406@freebsd.org> <09673101-DB54-4D25-9989-8C80D06E266B@fisglobal.com> <5283933E.30603@freebsd.org> <5283CBD1.9010606@freebsd.org> <86F0F59A-2DE0-42A3-9B8B-ADB1F3CA55A1@fisglobal.com> In-Reply-To: <86F0F59A-2DE0-42A3-9B8B-ADB1F3CA55A1@fisglobal.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.120] Content-Type: multipart/mixed; boundary="_002_7DD09B24F4D74ED483E2E9D72C157020fisglobalcom_" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.14, 0.0.0000 definitions=2013-11-14_03:2013-11-13,2013-11-14,1970-01-01 signatures=0 Cc: Devin Teske , FreeBSD Hackers , Alfred Perlstein , "Teske, Devin" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: Devin Teske List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 16:21:07 -0000 --_002_7DD09B24F4D74ED483E2E9D72C157020fisglobalcom_ Content-ID: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="Windows-1252" On Nov 13, 2013, at 4:58 PM, Teske, Devin wrote: >=20 > On Nov 13, 2013, at 10:58 AM, Alfred Perlstein wrote: >>=20 >> On 11/13/13, 10:01 AM, Jordan Hubbard wrote: >>>=20 >>> On Nov 13, 2013, at 6:57 AM, Alfred Perlstein wrot= e: >>>=20 >>>> It seems to work although I will talk to the team about making separat= e files for the set commands. >>>=20 >>> Since we=92re talking about this, there is an old maxim amongst FORTH p= rogrammers that if a single word=92s=20 >>> definition takes more than a page, it=92s just too dang long. There a= re some solid reasons for that, namely the fact that forth is already hard = enough to read as it is (and I=92m speaking as a FAN of the language) and y= ou generally need to keep the =93internal stack state=94 in your head while= writing a word since the stack contract is only at word boundaries (e.g. w= ord is defined as tacking stack parameters foo and returning stack paramete= rs bar). Keeping the definitions short and sweet really helps to aid in c= omprehension. >>>=20 >>> The definition for draw-beastie currently violates that maxim, and if y= ou guys were to refactor it as part of this work, I=92m sure future generat= ions would not object! :) >>=20 >> I'll give that a shot shortly. >>=20 >=20 Here's a patch to address that specifically... https://github.com/devinteske/freebsd/commit/c07adb2a17140d52a996ea6b8ddd94= 9b3c08be1b -or- https://github.com/devinteske/freebsd/commit/c07adb2a17140d52a996ea6b8ddd94= 9b3c08be1b.diff -or- See attached SVN patch.txt --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. --_002_7DD09B24F4D74ED483E2E9D72C157020fisglobalcom_ Content-Type: text/plain; name="patch.txt" Content-Description: patch.txt Content-Disposition: attachment; filename="patch.txt"; size=1841; creation-date="Thu, 14 Nov 2013 16:21:04 GMT"; modification-date="Thu, 14 Nov 2013 16:21:04 GMT" Content-ID: <76936954384AA24B9D4CAE8E7FCDB0EA@fisglobal.com> Content-Transfer-Encoding: base64 SW5kZXg6IHN5cy9ib290L2ZvcnRoL2JlYXN0aWUuNHRoDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gc3lzL2Jv b3QvZm9ydGgvYmVhc3RpZS40dGgJKHJldmlzaW9uIDI1NzgyMSkNCisrKyBzeXMvYm9vdC9mb3J0 aC9iZWFzdGllLjR0aAkod29ya2luZyBjb3B5KQ0KQEAgLTIwMiw1NiArMjAyLDI2IEBAIHZhcmlh YmxlIGxvZ29ZDQogCQlkcm9wDQogCXRoZW4NCiANCi0JcyIgbG9hZGVyX2xvZ28iIGdldGVudiBk dXAgLTEgPSBpZg0KLQkJbG9nb1ggQCBsb2dvWSBADQorCXMiIGxvYWRlcl9sb2dvIiBnZXRlbnYg ZHVwIC0xIDw+IGlmDQorCQlkdXAgNSArIGFsbG9jYXRlIGlmIEVOT01FTSB0aHJvdyB0aGVuDQor CQkwIDJzd2FwIHN0cmNhdCBzIiAtbG9nbyIgc3RyY2F0DQorCQlvdmVyIC1yb3QgKCBhLWFkZHIv dSAtLSBhLWFkZHIgYS1hZGRyL3UgKQ0KKwkJc2ZpbmQgICAgICggYS1hZGRyIGEtYWRkci91IC0t IGEtYWRkciB4dCBib29sICkNCisJCXJvdCAgICAgICAoIGEtYWRkciB4dCBib29sIC0tIHh0IGJv b2wgYS1hZGRyICkNCisJCWZyZWUgICAgICAoIHh0IGJvb2wgYS1hZGRyIC0tIHh0IGJvb2wgaW9y ICkNCisJCWlmIEVGUkVFIHRocm93IHRoZW4NCisJZWxzZQ0KKwkJMCAoIGNydWZ0IC0tIGNydWZ0 IGJvb2wgKSBcIGxvYWQgdGhlIGRlZmF1bHQgYmVsb3cNCisJdGhlbg0KKwkwPSBpZg0KKwkJZHJv cCAoIGNydWZ0IC0tICkNCiAJCWxvYWRlcl9jb2xvcj8gaWYNCi0JCQlvcmItbG9nbw0KKwkJCVsn XSBvcmItbG9nbw0KIAkJZWxzZQ0KLQkJCW9yYmJ3LWxvZ28NCisJCQlbJ10gb3JiYnctbG9nbw0K IAkJdGhlbg0KLQkJZHJvcCBleGl0DQogCXRoZW4NCi0NCi0JMmR1cCBzIiBiZWFzdGllIiBjb21w YXJlLWluc2Vuc2l0aXZlIDA9IGlmDQotCQlsb2dvWCBAIGxvZ29ZIEAgYmVhc3RpZS1sb2dvDQot CQkyZHJvcCBleGl0DQotCXRoZW4NCi0JMmR1cCBzIiBiZWFzdGllYnciIGNvbXBhcmUtaW5zZW5z aXRpdmUgMD0gaWYNCi0JCWxvZ29YIEAgbG9nb1kgQCBiZWFzdGllYnctbG9nbw0KLQkJMmRyb3Ag ZXhpdA0KLQl0aGVuDQotCTJkdXAgcyIgZmJzZGJ3IiBjb21wYXJlLWluc2Vuc2l0aXZlIDA9IGlm DQotCQlsb2dvWCBAIGxvZ29ZIEAgZmJzZGJ3LWxvZ28NCi0JCTJkcm9wIGV4aXQNCi0JdGhlbg0K LQkyZHVwIHMiIG9yYiIgY29tcGFyZS1pbnNlbnNpdGl2ZSAwPSBpZg0KLQkJbG9nb1ggQCBsb2dv WSBAIG9yYi1sb2dvDQotCQkyZHJvcCBleGl0DQotCXRoZW4NCi0JMmR1cCBzIiBvcmJidyIgY29t cGFyZS1pbnNlbnNpdGl2ZSAwPSBpZg0KLQkJbG9nb1ggQCBsb2dvWSBAIG9yYmJ3LWxvZ28NCi0J CTJkcm9wIGV4aXQNCi0JdGhlbg0KLQkyZHVwIHMiIHRyaWJ1dGUiIGNvbXBhcmUtaW5zZW5zaXRp dmUgMD0gaWYNCi0JCWxvZ29YIEAgbG9nb1kgQA0KLQkJcyIgdHJpYnV0ZS1sb2dvIiBzZmluZCBp Zg0KLQkJCWV4ZWN1dGUNCi0JCWVsc2UNCi0JCQlkcm9wIG9yYi1sb2dvDQotCQl0aGVuDQotCQky ZHJvcCBleGl0DQotCXRoZW4NCi0JMmR1cCBzIiB0cmlidXRlYnciIGNvbXBhcmUtaW5zZW5zaXRp dmUgMD0gaWYNCi0JCWxvZ29YIEAgbG9nb1kgQA0KLQkJcyIgdHJpYnV0ZWJ3LWxvZ28iIHNmaW5k IGlmDQotCQkJZXhlY3V0ZQ0KLQkJZWxzZQ0KLQkJCWRyb3Agb3JiYnctbG9nbw0KLQkJdGhlbg0K LQkJMmRyb3AgZXhpdA0KLQl0aGVuDQotDQotCTJkcm9wDQorCWxvZ29YIEAgbG9nb1kgQCByb3Qg ZXhlY3V0ZQ0KIDsNCiANCiA6IGNsZWFyLWJlYXN0aWUgKCAtLSApIFwgY2xlYXJzIGJlYXN0aWUg ZnJvbSB0aGUgc2NyZWVuDQo= --_002_7DD09B24F4D74ED483E2E9D72C157020fisglobalcom_--