From nobody Thu Jan 29 15:39:51 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f23HC4yvyz6Qrjm for ; Thu, 29 Jan 2026 15:39:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f23HC2DBZz3xqV for ; Thu, 29 Jan 2026 15:39:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769701191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=izuFcHchJ1F5RgwtT1NAsMVWzBCJ6RsssCdM3MxVsCk=; b=xj7VlRauxmpuLGtOXzjyE7BEqFyAKl9//Hx3dIqBALzHUTRoy343iGQHiTM1zbXupXDYS2 y0Kt+4Tdm+WwIwk9VRm3xCNTUIf2lzk8bn6IQD2sCVAgqPE4Zf9Z/qOA/0q4L9t4z6xI7U mTYc8W7RX9+woIhYMOZqRFZ67BJPNWtDT5I3NHsgZOe3n8Ikiudsa0FIZZNHcM4ApkQQA3 W3/CHJTn7F+L2ejY0sMFT43e3P32ROoOgJmbRQd/G7+cs9+97uNzeVNUGYIDX2e92AJ2l8 cfpmbEI/boM26dFGZIvNuYvlFGtT40mm0Lb6lRxjUIAD337E7+ncVer0Z8hm5g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769701191; a=rsa-sha256; cv=none; b=JcULwV/JfhSWoxjBNLbCecnR6kinjRgyqidIS188SYYwAUGcLblsUz99FRlHH8UXQNHVIr qz5HnMYfkeWsnt+iOe6VgP6GD0/1W7ODGv+qCN1lnr6nemn3uPl3HrWUHnLwYMq+8K6UEV W1c9jLX3KqXMljYgCrr30M9hByVkmRcYA+qW+Ie9Vzqg0VaXhaZzdmP0n0Gh6t16h3DDml ZFs+iW3jTXEzrb6UG2PWXUUSN0j+x0cvKSnUhZs+Gh29jugM5SPNYCyNk2/W1mcG4z8meT Do63952YzbLvbqAQr/yfm+IPOPYANbF63vn8n2Z5PFStFEyaPaNR7HylzzJKoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769701191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=izuFcHchJ1F5RgwtT1NAsMVWzBCJ6RsssCdM3MxVsCk=; b=GD8UuYkDHIbTgtC1wPFxHFS9XxPv5gmzgLO9saZOfkCrPay5OcX9xfeGUZUvFv/ytSsRtZ gWyApelVZ3wfDhFscAjCV5X6aE6UnysI31L/hxrJ6XG1W+FQhmQ1kKRXu/pIkNG6+gzQRA YIYt9XLvQpGly4boZlsW5ENr6pPFos9Q04apIAtNXsg3RovN+sG1zNiV86DopwJZnS92TK ZfeZiPbR/SRb87lb5IxuKviRV2JuQRdZ2oDS1SVl8E4kbqJSEZ+xeMcRmXFsiu5zDCZlK1 G6fLjDUsSjz7Gpe5pAuEN+2crJfQDRfFmsBtSk5RwPOOsw5HoypwGmvNfRR28A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f23HC1hZHzkYT for ; Thu, 29 Jan 2026 15:39:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38e50 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Jan 2026 15:39:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 7982c36da11c - stable/14 - kyua: Don't pass NULL to unique_ptr constructors List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7982c36da11c94ac8ece46b23fadcf607d0e8396 Auto-Submitted: auto-generated Date: Thu, 29 Jan 2026 15:39:51 +0000 Message-Id: <697b7f47.38e50.60ba5a15@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=7982c36da11c94ac8ece46b23fadcf607d0e8396 commit 7982c36da11c94ac8ece46b23fadcf607d0e8396 Author: John Baldwin AuthorDate: 2025-05-03 15:58:47 +0000 Commit: John Baldwin CommitDate: 2026-01-29 15:17:28 +0000 kyua: Don't pass NULL to unique_ptr constructors This is ambiguous when NULL is defined to an integral constant. Instead, use the more iodiomatic pattern of {} to construct a default pointer. Reviewed by: olce Differential Revision: https://reviews.freebsd.org/D50090 (cherry picked from commit 26d4ac7a2725c0ab2d536c402fc0185fe7afed85) --- contrib/kyua/utils/process/child.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/kyua/utils/process/child.cpp b/contrib/kyua/utils/process/child.cpp index bfde8159d5c8..d554f1fd9fb5 100644 --- a/contrib/kyua/utils/process/child.cpp +++ b/contrib/kyua/utils/process/child.cpp @@ -223,7 +223,7 @@ process::child::fork_capture_aux(void) std::cerr << F("Failed to set up subprocess: %s\n") % e.what(); std::abort(); } - return std::unique_ptr< process::child >(NULL); + return {}; } else { ::close(fds[1]); LD(F("Spawned process %s: stdout and stderr inherited") % pid); @@ -284,7 +284,7 @@ process::child::fork_files_aux(const fs::path& stdout_file, std::cerr << F("Failed to set up subprocess: %s\n") % e.what(); std::abort(); } - return std::unique_ptr< process::child >(NULL); + return {}; } else { LD(F("Spawned process %s: stdout=%s, stderr=%s") % pid % stdout_file % stderr_file);