From owner-freebsd-x11@FreeBSD.ORG Tue Mar 1 21:05:47 2011 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C0D3106564A for ; Tue, 1 Mar 2011 21:05:47 +0000 (UTC) (envelope-from wblock@wonkity.com) Received: from wonkity.com (wonkity.com [67.158.26.137]) by mx1.freebsd.org (Postfix) with ESMTP id E5A988FC14 for ; Tue, 1 Mar 2011 21:05:46 +0000 (UTC) Received: from wonkity.com (localhost [127.0.0.1]) by wonkity.com (8.14.4/8.14.4) with ESMTP id p21L5kwN056470; Tue, 1 Mar 2011 14:05:46 -0700 (MST) (envelope-from wblock@wonkity.com) Received: from localhost (wblock@localhost) by wonkity.com (8.14.4/8.14.4/Submit) with ESMTP id p21L5jBP056467; Tue, 1 Mar 2011 14:05:45 -0700 (MST) (envelope-from wblock@wonkity.com) Date: Tue, 1 Mar 2011 14:05:45 -0700 (MST) From: Warren Block To: Roland Smith In-Reply-To: Message-ID: References: <20110228221844.GA2957@compaq.yuetime> <20110301191536.GA28125@slackbox.erewhon.net> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.6 (wonkity.com [127.0.0.1]); Tue, 01 Mar 2011 14:05:46 -0700 (MST) Cc: freebsd-x11@freebsd.org Subject: Re: xf86-video-ati with patch-src-radeon_driver.c freeze the system X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2011 21:05:47 -0000 ...Well, that was interesting. Swapped out my 4650 and X1650 cards again, and starting X locked up. I swear it worked a couple of days ago when I tested it with the stock port patches. Just swapped it for my normal HD4650. FreeBSD lightning 8.2-STABLE FreeBSD 8.2-STABLE #0: Mon Feb 28 18:43:21 MST 2011 root@lightning:/usr/obj/usr/src/sys/LIGHTNING i386 X1650: 512M, PCIE: mem_size 20000000, aper_size 0 HD4650: 512M, PCIE: mem_size 20000000, aper_size 0 Yet the HD4650 has worked every time... Is the original patch outdated? Here's the code: /* Fix for RN50, M6, M7 with 8/16/32(??) MBs of VRAM - Novell bug 204882 + along with lots of ubuntu ones */ if (aper_size > mem_size) mem_size = aper_size; /* don't map the whole FB in the internal address space. * we don't currently use fb space larger than the aperture * size and on cards with more than 512 MB of vram, this can overflow * the internal top of gart calculation on some systems. * Limit it to cards with more than 512 MB as this causes problems * on some other cards due to the way the ddx and drm set up the * internal memory map. * See fdo bug 24301. */ And then the patch, with the exact opposite test: if (mem_size > aper_size) mem_size = aper_size; So unless they are equal, mem_size will be set to aper_size afterwards. The original code continues: if (mem_size > 0x20000000) mem_size = aper_size; Looks to me like it's not getting out of there without setting mem_size to zero. Whether aper_size should really be zero, no idea. That seems like an upstream bug.