Date: Thu, 27 Feb 2014 09:20:05 GMT From: =?UTF-8?B?RnLDqWTDqXJpYw==?= Praca <frederic.praca@free.fr> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/186976: [PATCH] devel/tortoisehg2 upgrade to 2.11 Message-ID: <201402270920.s1R9K5DL071253@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/186976; it has been noted by GNATS. From: =?UTF-8?B?RnLDqWTDqXJpYw==?= Praca <frederic.praca@free.fr> To: arrowdodger <6yearold@gmail.com> Cc: bug-followup@freebsd.org Subject: Re: ports/186976: [PATCH] devel/tortoisehg2 upgrade to 2.11 Date: Thu, 27 Feb 2014 10:19:07 +0100 > Hello, Fr=C3=A9d=C3=A9ric. Hello, =20 > Thanks for your patch. Could you, please, explain me your changes to > pkg-plist? > Specifically, removing %%NAUTILUS%% and %%NLS%% stuff, replacing > @dirrm's with @dirrmtry's for share/pixmaps/tortoisehg and addition of >=20 > +@dirrmtry %%PYTHON_SITELIBDIR%%/tortoisehg-2.11-py2.7.egg-info > +@dirrmtry %%PYTHON_SITELIBDIR%%/tortoisehg >=20 > These entries are added automatically by >=20 > USE_PYDISTUTILS=3Dyes > INSTALLS_EGGINFO=3Dyes >=20 > lines from Makefile. Well, according to http://www.freebsd.org/doc/en/books/porters-handbook/plist-autoplist.html , I just used "make makeplist" :) I also removed what seemed to be overkill such as : @dirrmtry %%PYTHON_SITELIBDIR%% But, you are right, tortoisehg directories could be just deleted with dirrm. About %%NAUTILUS%% and %%NLS%% stuff, it seems that the autoplist target forgot these files. I will check it as soon as possible to provide you a new patch. > Otherwise your patch looks good. Thanks but changing PORTVERSION in the Makefile, updating distinfo and regenerating the plist automatically is not really a big thing :D Fred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402270920.s1R9K5DL071253>