From owner-freebsd-net@FreeBSD.ORG Wed Jun 10 21:31:50 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0273106566C for ; Wed, 10 Jun 2009 21:31:50 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.250]) by mx1.freebsd.org (Postfix) with ESMTP id 6605B8FC13 for ; Wed, 10 Jun 2009 21:31:50 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by an-out-0708.google.com with SMTP id c3so573555ana.13 for ; Wed, 10 Jun 2009 14:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=/KiTGkuV+HQymWreoVpuOGFQvxmlXx55uJLclENh2Ys=; b=eci40pwA+0hUwcuU/5D1OGcE4W+/t6cE02n0SynOmXLqSN1OIT5y4byduYLEI7aeVs Xyfp3W9jy30toq1B2dPYjUyGkvGM/xt9imbkejacZPy+FA8YqXX8CqcxvbkiNPV7jMfX D5mmneQaByNvC/3IMIdoAtZ+2k7/Bgue5EA0A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=q3VD7V17j1JUh1fRRwv6UUgkVIFJ8fePeYYsIHFJAUPH4R9ZCkFpTFm9ctNQFFuwzO RTOFe6vT8oSLoBxZLIpItc2SV1/uc1Z7ds2W3mGC3dc7Idl40UqUo9BHlioz1rrB92vT VZagfjLhsKFLDupgAQtL1HhSjfmOfS7UtAz4w= MIME-Version: 1.0 Sender: mat.macy@gmail.com Received: by 10.100.58.1 with SMTP id g1mr1897925ana.181.1244669509485; Wed, 10 Jun 2009 14:31:49 -0700 (PDT) In-Reply-To: <3c1674c90906101417j39a01f85k8e98c0ee19a011a7@mail.gmail.com> References: <20090610210021.N22887@maildrop.int.zabbadoz.net> <3c1674c90906101417j39a01f85k8e98c0ee19a011a7@mail.gmail.com> Date: Wed, 10 Jun 2009 14:31:49 -0700 X-Google-Sender-Auth: e3642c7a9e255e75 Message-ID: <3c1674c90906101431x7b556855pd3103d9e7a9f26dc@mail.gmail.com> From: Kip Macy To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-net@freebsd.org Subject: Re: fxp hack in sys/net/if.c? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 21:31:51 -0000 The reasoning behind moving the delay in to shared code is not very compell= ing. -Kip On Wed, Jun 10, 2009 at 2:17 PM, Kip Macy wrote: > From "cvs blame": > > Add workaround for fxp issue at interface initialization with IPv6. > > =A0Some LAN card chip for fxp is known to cause problem at > =A0interface initialization with IPv6 enabled. It happens at > =A0some delicate timing. > =A0And also, just adding some DELAY before IPv6 address > =A0autoconfiguration is known to avoid the problem. > > =A0Complete fix is changing the driver not to use interrupt at > =A0multicast filter initialization, but trying such change in > =A0this stage will be dangerous. > > =A0So I add some DELAY() only inside #ifdef INET6 part, > =A0as temporal workaround only for 4.0. > > Approbed by: jkh > > Noticed by: Mattias Pantzare > > Obtained from: openbsd-tech mailing list > > > > On Wed, Jun 10, 2009 at 2:03 PM, Bjoern A. > Zeeb wrote: >> Hi, >> >> could anyone having a clue why that is there look at it and either >> remove it or remove it and properly handle it elsewhere? >> >> I have continuesly noticed it for a while so I think the "temporary" >> as given in the comment rather means "forgotten"? >> >> sys/net/if.c: =A0 =A0 =A0 =A0 =A0 DELAY(100);/* XXX: temporary workaroun= d for fxp >> issue*/ >> >> /bz >> >> -- >> Bjoern A. Zeeb =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0The greatest r= isk is not taking one. >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > > > > -- > When bad men combine, the good must associate; else they will fall one > by one, an unpitied sacrifice in a contemptible struggle. > > =A0 =A0Edmund Burke > --=20 When bad men combine, the good must associate; else they will fall one by one, an unpitied sacrifice in a contemptible struggle. Edmund Burke