From owner-freebsd-net@freebsd.org Wed Jul 22 09:28:43 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41D859A7F12 for ; Wed, 22 Jul 2015 09:28:43 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 147BA198D for ; Wed, 22 Jul 2015 09:28:43 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mailman.ysv.freebsd.org (Postfix) id 115ED9A7F0F; Wed, 22 Jul 2015 09:28:43 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10E439A7F0C for ; Wed, 22 Jul 2015 09:28:43 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pd0-x22f.google.com (mail-pd0-x22f.google.com [IPv6:2607:f8b0:400e:c02::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C9A21198A for ; Wed, 22 Jul 2015 09:28:42 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by pdrg1 with SMTP id g1so135911767pdr.2 for ; Wed, 22 Jul 2015 02:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=+X+aU29cdQ63tQkvfYkBCvW/NdjQ9et+0HQaIR7ynYg=; b=iZsPd6IspOeeZXxgRuH87oxmtO+HMKZN1uzBbY34VuzKPbIvfKN+GE1n+Z9KXWL4ih LRvfsDGgr9RN9+/+NLMKE643iFo4hMALjNgtBqNXMdSRZPMFj6w2Xx0ROzCC64UYeSBm T/dyiHpjYb95Dn1ly10Zy16Xpulrapzh8oRXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=+X+aU29cdQ63tQkvfYkBCvW/NdjQ9et+0HQaIR7ynYg=; b=Wpi3hx+Y9LeNtEV2QHqixbLmol2bf/OKHdfMdzd1goTLokT3VmB7LElt0y844uD+D6 tMS11HFpd6pwsFSOxfjj+/crvjJc1NPBC3Z/ugYtqD6rmZHvNB4rM/ixWD1Zv0JgqlpN Zpwnb0ItMFSP70ul0kH8mCRHxdsBMuxoRdLgITupaAr+Zb/+fzhKjeZVJ6eHGMBZtliI nxKzMidbYCeqBVhHAC9J14+IC1DwntXpNJxb0cuvP3x062wXvhqzF/s4Hf7HohYCmRxo ZdqvAXs8Q1xOysbdRGKDTsYQ4iwhmLQ4yj4ttXjR8RcVtszKRPimA0d7nEJgACuuioZP Kj4g== X-Gm-Message-State: ALoCoQlKe/vR3/y1joVqkS3aoeWkCSuU3zmaxokrmQz3wg3GmqTgYoQp4FI2OyPdVgBjM4z+n0hj X-Received: by 10.70.1.7 with SMTP id 7mr4051441pdi.38.1437557322247; Wed, 22 Jul 2015 02:28:42 -0700 (PDT) Received: from ?IPv6:2001:67c:370:160:9433:63eb:6a5e:13cb? ([2001:67c:370:160:9433:63eb:6a5e:13cb]) by smtp.gmail.com with ESMTPSA id l1sm2112419pdp.71.2015.07.22.02.28.39 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Jul 2015 02:28:41 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: panic: witness_warn head/amd64 @r285741 on 1 of 2 machines From: Randall Stewart In-Reply-To: <20150721215907.GM27865@albert.catwhisker.org> Date: Wed, 22 Jul 2015 05:28:33 -0400 Cc: Eric van Gyzen , Konstantin Belousov , current@freebsd.org, net@freebsd.org, Randall Ray Stewart Message-Id: <6333F7DC-C74E-4B13-AABD-6FD8A5C49742@netflix.com> References: <20150721125734.GF1217@albert.catwhisker.org> <20150721133907.GR2404@kib.kiev.ua> <20150721161927.GN1217@albert.catwhisker.org> <20150721191743.GA39506@muskytusk> <20150721192832.GB2404@kib.kiev.ua> <20150721200515.GD27865@albert.catwhisker.org> <55AEA9BC.5070806@vangyzen.net> <20150721215907.GM27865@albert.catwhisker.org> To: David Wolfskill X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 09:28:43 -0000 David Yep.. we got that wrong. If 1 is returned by the submit it means the PCB was lost. If 0 is returned you unlock as usual. R On Jul 21, 2015, at 5:59 PM, David Wolfskill = wrote: > On Tue, Jul 21, 2015 at 03:21:16PM -0500, Eric van Gyzen wrote: >> ... >>>> So it looks like net swi, leaking some udp6 lock. >>> Curiouser and curiouser... While I'm not taking any special pains = to >>> avoid building IPv6, I'm not actively actually doing anything with = it >>> (IPv6), either (for both the failing machine and my laptop). >>>=20 >>> Once I'm back home, I should be able to poke around in ddb after >>> re-creating the panic, if that would be a useful thing for me to do = (and >>> given some hints as to what to poke). >>>=20 >>> Naturally, I'm also happy to change bits of sources, rebuild, and >>> smoke-test. >>>=20 >>> A quick check from the SVN update output only shows r285710, = r285711, and >>> r285740 in the range from (r285685,r285741] -- as the kernel running >>> r285685 had no known issues -- that touched sys/netinet6/*. >>=20 >> It's a multicast destination. Maybe something is using mDNS? >>=20 >> Randall, does the test on line 406 of udp6_usrreq.c need to be = inverted? >>=20 >> Eric >>=20 >=20 > We have a winner! >=20 > FreeBSD freebeast.catwhisker.org 11.0-CURRENT FreeBSD 11.0-CURRENT = #1789 r285741M/285741:1100077: Tue Jul 21 14:50:59 PDT 2015 = root@freebeast.catwhisker.org:/common/S3/obj/usr/src/sys/GENERIC amd64 >=20 > freebeast(11.0-C)[3] cd /usr/src > freebeast(11.0-C)[4] svn diff sys/netinet > netinet/ netinet6/=20 > freebeast(11.0-C)[4] svn diff sys/netinet* > Index: sys/netinet6/udp6_usrreq.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/netinet6/udp6_usrreq.c (revision 285741) > +++ sys/netinet6/udp6_usrreq.c (working copy) > @@ -403,7 +403,7 @@ > INP_RLOCK(last); > INP_INFO_RUNLOCK(pcbinfo); > UDP_PROBE(receive, NULL, last, ip6, last, uh); > - if (udp6_append(last, m, off, &fromsa))=20 > + if (! udp6_append(last, m, off, &fromsa))=20 > INP_RUNLOCK(last); > inp_lost: > return (IPPROTO_DONE); > freebeast(11.0-C)[5]=20 >=20 > Thanks! :-) >=20 > Peace, > david > --=20 > David H. Wolfskill david@catwhisker.org > Those who murder in the name of God or prophet are blasphemous = cowards. >=20 > See http://www.catwhisker.org/~david/publickey.gpg for my public key. -------- Randall Stewart rrs@netflix.com 803-317-4952