From owner-dev-commits-src-main@freebsd.org Sat Apr 10 15:27:57 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8CF835CFA26 for ; Sat, 10 Apr 2021 15:27:57 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FHf5T3K61z3hnT for ; Sat, 10 Apr 2021 15:27:57 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk1-x72f.google.com with SMTP id o5so9010918qkb.0 for ; Sat, 10 Apr 2021 08:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Wm0hHA2juysPoxxyL+aoV14wRM+y6dvLeN2sJIh0kFc=; b=hMko1qDl8b5tHTTz6t17Xu214ubtk73Ih1rLmJwLFztE2ITcbbraCPLXOOnGwzszMx oNuK5WA2umTO6kgK0JMi3gOTXWfcaTz4aSb/iaVcpERA7yJkvfmuFCMuLI+FuQBmfFjs gtpI7SvxbWozfdjMaT4zMRk6BqTTNM3tBPFaoLK+BS6YziY4xTImmsusYqXtyH5yuiB+ KgvDyGim0mN3MTOqjQZzFZCSigI2QjMD3bxYF8X30ZB/NKFt0cDgPZS8uZM9u1433t7W Ixn6ovLem1na8UjKQtI62ZXtGZDryJITCr2n1OvYegezK3WD07G2Gkq44oyJOxbolfqy +7iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Wm0hHA2juysPoxxyL+aoV14wRM+y6dvLeN2sJIh0kFc=; b=RTOTbawHNyvD2+R03xB4or2pJ2/cYj4N4vexQwBmNiHM8NTvTN1U5s42DfGW3yKrWT iFpOiqvvIOmufWa0kdSZW+OsvDZ6MEb06ESd1t9SooaKW6juo+LEIiZfzWCxKcH5FJq6 IGX+HMT1u7SNP40Jnxt2dwystSuk4vkMIK8F9kysV6TpoPh6YU8vU3YnwXt1HFRtnGXV NqQQXuGJnJKSM/CYFXscE6mml0mdhvDEzG/qhSYiqFE47NrWAduOXt5W2jqpcU3YV4qY z5Fzo01ojut1N63rT0vKyZu5WxeamYFpficdgHeAG3HGh5l0i68kyxMJcvS70KNplURw xMlg== X-Gm-Message-State: AOAM530r/RVXpS6DW0266wMGreK8CqvIsm6qdAMnYeeoIb3hz9JNvGx5 nIGgIERcdg4mX0w4xnGrMpEDu5mWbDLEm0V+ X-Google-Smtp-Source: ABdhPJwofQeIRZRvxkN2L2T0h1fsmei3q5VAkLVZAFfn9M8qaZGpKMokCEusONwM5U14MtuQQnJBTQ== X-Received: by 2002:a05:620a:108f:: with SMTP id g15mr19650939qkk.298.1618068476310; Sat, 10 Apr 2021 08:27:56 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id e14sm3908095qte.78.2021.04.10.08.27.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 08:27:55 -0700 (PDT) Date: Sat, 10 Apr 2021 11:27:54 -0400 From: Shawn Webb To: Kristof Provost Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 0dd13c77432a - main - libnv: Build PIC Message-ID: <20210410152754.4isx26qyvz6k3qbo@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202104100916.13A9GMOp069019@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bn3s3dhmbz3p573s" Content-Disposition: inline In-Reply-To: <202104100916.13A9GMOp069019@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4FHf5T3K61z3hnT X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2021 15:27:57 -0000 --bn3s3dhmbz3p573s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 10, 2021 at 09:16:22AM +0000, Kristof Provost wrote: > The branch main has been updated by kp: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0dd13c77432ade1ae94c9661cb= ad5537e3e6ab1d >=20 > commit 0dd13c77432ade1ae94c9661cbad5537e3e6ab1d > Author: Kristof Provost > AuthorDate: 2021-04-02 15:06:02 +0000 > Commit: Kristof Provost > CommitDate: 2021-04-10 09:16:01 +0000 >=20 > libnv: Build PIC > =20 > Build libnv as position independent code so we can use it from shared > libraries. > =20 > MFC after: 4 weeks > Sponsored by: Rubicon Communications, LLC ("Netgate") > Differential Revision: https://reviews.freebsd.org/D29561 > --- > lib/libnv/Makefile | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/libnv/Makefile b/lib/libnv/Makefile > index b13758931c4e..854cd2c7f3f3 100644 > --- a/lib/libnv/Makefile > +++ b/lib/libnv/Makefile > @@ -10,6 +10,7 @@ SHLIB_MAJOR=3D 0 > =20 > .PATH: ${SRCTOP}/sys/contrib/libnv ${SRCTOP}/sys/sys > CFLAGS+=3D-I${.CURDIR} > +CFLAGS+=3D-fPIC Wouldn't the better fix be renaming LIB to SHLIB like every other PIC lib? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --bn3s3dhmbz3p573s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBxw/gACgkQ/y5nonf4 4fqb9Q//QQXXForXJWJb9XCneQhDkG+++fMY8Qyfed7UJCZ8exmk9GPl9TiQgt+h tX62sdpSqTUCHXlXd+xa+zUc/RvXz8vBXXTtNRIlkaNuP1HWCkioS0QQ+u5Or4NP VQFsBnysiynLzd9WEl/fykA2O9vQ7lVjs0HOsl2KDp6pG13/k2kAG7XPg7ZHezrq qDsrAkrIaYVK5BTltVZghv/l5ZsbYJo8mYfYgbKBZocceMw20HaR7uHvbRt3C6Ju efvrBOpzcdaeZG/WU+chm+r7yh80pWQuCrg7sFgc+/6Q6ZWrz8zazxKG4UK3pb/L DPm6ThozdlC3+mc3naIHgK6dXtgh41avTvU/dl4ZGtliuSUfUR1NHQmZ41/hZTGK JM/4socOUOCw6e+llK2cgFsFwOzHup5xbyb2CeCnH/MSqgmCyC1RaPenkqrzSVmq HTJjDVxyhT3UTycIak6NFmDbja9MAu6Sw0KSiVCfAH6T/vThzxqKs35vS09AAJ0m Xz3qpSKylYuwkKlX2OCeFVizfd7cg4Z2tLIilyVjZuiQZjDu1UksSFSXFKwbjZCz tBTefSnat4SDh42mXl2BPJ7NbzySthtqAx5s5QtYNwnFMAhOhKtEdlojqjLGuU9I TkHqnPHTJ6jDNdFUi+3YdkXSp06Kc/JfNMpSWj1LX54xPwPDvRg= =th8p -----END PGP SIGNATURE----- --bn3s3dhmbz3p573s--