From nobody Tue Feb 1 14:56:59 2022 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8EB5C19AB9B0 for ; Tue, 1 Feb 2022 14:56:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jp7Lg2fdhz4nmP for ; Tue, 1 Feb 2022 14:56:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3B93D12564 for ; Tue, 1 Feb 2022 14:56:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 211EuxYC092131 for ; Tue, 1 Feb 2022 14:56:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 211Euxvr092130 for x11@FreeBSD.org; Tue, 1 Feb 2022 14:56:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 261654] x11/libinput: enabling DEBUG_GUI fails to build Date: Tue, 01 Feb 2022 14:56:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hiroo.ono+freebsd@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643727419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TneDc11aCj5s95p4adGPbEaTTEBMz/LH95mvpyUZ9uE=; b=xL8rfWykkU/yg07Q4oJbzxPft6iPTju2xf4HS20ZTzCQ1gskMr515VuxUN7D1a7XBxAH+L KTABufuHfVai7sjvN57LmQfTXqFtWqwdRJ5T8cbwM9I8e+o25VJ8Dxm/7cDws+w0dH0oAE M3mHdmoaW9iEd+qXVFyZgp1Q58sYXWh99McHmcqLbnlSyN3NaGOHjuHZTw9xxvH4GnVD+6 ecWDxsGbS2Vvtb4nrhxqVWM6brDHmN7FH+AMMjjDG7V+Pb3lOIFGChDSnvRgDUcQks/0QL yBwhd0aQrQhJEUNEesk7RGu/iZHMe63ANUBQ3y4QEsr25Z8qYyM6S2o4q5ODLQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643727419; a=rsa-sha256; cv=none; b=u6/bddXrK9bSXsxFvmXwfcff7Vn4VXdi5ETbd4Dkos0gGP2LrDpFJ/GfHDdDFHtC+uqeyu ALGbZ5VHo67e5lio6ojRS0b29rfI4f65+/GAbgQcC+Kn3+tzbVzoTESi7bJKgxOzjgoKXo xjPnOV/BdogAXF/AdzHu6l241lgJwPtyRqrGFzX5NJYGRRxT/h+MLr96qHorH1zSOlruQ6 PwHJ07ToEjTP52ISxIDP8ojHp16uAD5jAmQPSX8d6hQ1UZqTvkGQXXpgr2r4OFgCRlYag7 fiD13SENhRROpiEHSvj8PpZqfOn5l0q1ZRvK5Xo2GYw44MwJA5LVsmt/AB6PUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261654 Bug ID: 261654 Summary: x11/libinput: enabling DEBUG_GUI fails to build Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: x11@FreeBSD.org Reporter: hiroo.ono+freebsd@gmail.com Flags: maintainer-feedback?(x11@FreeBSD.org) Assignee: x11@FreeBSD.org Created attachment 231495 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D231495&action= =3Dedit pull wayland in. Enabling DEBUG_GUI option in x11/libinput fails to build. Requiring wayland and wayland-protocols as the attached patch makes it buil= d, but I am not sure if it is the right solution. 1) libinput-debug-gui.c =20 https://gitlab.freedesktop.org/libinput/libinput/-/blob/e9ccd4f402a8b56590a= cc83009f4045b145587bf/tools/libinput-debug-gui.c includes "pointer-constraints-unstable-v1-client-protocol.h" when GDK_WINDOWING_WAYLAND is defined. 2) GDK_WINDOWING_WAYLAND is defined in /usr/local/include/gtk-3.0/gdk/gdkconfig.h without any condition. I did not verify but is it because I enabled WAYLAND in x11-toolkits/gtk3= 0? 3) libinput's meson.build =20 https://gitlab.freedesktop.org/libinput/libinput/-/blob/e9ccd4f402a8b56590a= cc83009f4045b145587bf/meson.build only provides "pointer-constraints-unstable-v1-client-protocol.h" when wayland-client and wayland-protocols are found. What I am not sure is: is GDK_WINDOWING_WAYLAND in gdkconfig.h is always defined? Isn't it defined only when option WAYLAND is enabled in x11-toolkits/gtk30? Then how do I detect it in x11/libinput's port Makefile? The log is as follows: cc -Ilibinput-debug-gui.p -I. -I.. -I../src -I../include -I/usr/local/include/libepoll-shim -I/usr/local/include/gtk-3.0 -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/harfbuzz -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include/fribidi -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/gio-unix-2.0 -I/usr/local/include/atk-1.0 -I/usr/local/include/at-spi2-atk/2.0 -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include -I/usr/local/include/at-spi-2.0 -I/usr/local/include/libevdev-1.0 -I/usr/local/include/libwacom-1.0 -I/usr/local/include/gudev-1.0 -fno-color-diagnostics -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -std=3Dgnu99 -O3 -Wno-unused-parameter -Wmissing-prototypes -Wstrict-protot= ypes -Wundef -Wpointer-arith -Wuninitialized -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough -Wredundant-decls -Wincompatible-pointer-types -Wformat=3D2 -Wno-missing-field-initializers -Wmissing-declarations -fvisibility=3Dhidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -pthread -D_THREAD_SAFE -MD -MQ libinput-debug-gui.p/tools_libinput-debug-gui.c.o -MF libinput-debug-gui.p/tools_libinput-debug-gui.c.o.d -o libinput-debug-gui.p/tools_libinput-debug-gui.c.o -c ../tools/libinput-debug-gui.c ../tools/libinput-debug-gui.c:53:11: fatal error: 'pointer-constraints-unstable-v1-client-protocol.h' file not found #include "pointer-constraints-unstable-v1-client-protocol.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. --=20 You are receiving this mail because: You are the assignee for the bug.=