From owner-svn-src-all@freebsd.org Wed Jun 10 23:44:26 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A608E34257F; Wed, 10 Jun 2020 23:44:26 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49j3Vd504tz3TFV; Wed, 10 Jun 2020 23:44:25 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ed1-f49.google.com with SMTP id k8so2653296edq.4; Wed, 10 Jun 2020 16:44:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=bxsynl9UOgnLB83v82NU0Z40ADvTm2JpqmAJCj2jFjQ=; b=SXojiuUKZHjxhdwyqk/wVdWEXU5I39QqNv/ts87jJWIx5s2P2teMzL6VBF/C9SzUgV ZO2LHF85fWOT2zgB+b5kiBQG51kC/CdyzcSUpdV2a/MuU2abGKNEIWlYPEpZcvcZkXwR w9aozBHYPHEW5EiWlBm7sL0pGABmHlg4AoY9HF6AEw6Eo2bNAMrGPZuF0zpnygN4XHBb Syww1tvsKEbr4sOLdOJojlkqIkXOSwKO0RjXj9a0Qg+qAlAo31lkmBK7fTJzcydmd3iZ m1HTU23QZyQ4d+UtgLffEvyj/9SaKlmvbxhvh/LFrzuM27lI92C4TuCUCUVks5OnYC0j 5WSg== X-Gm-Message-State: AOAM531NOurzIOW5XD4UVjH9J1qfe9gHgi5erG+1cka303oVLRpTYkby 7D/b8unaTJHlVaOskkFLWqBdX4tPg7Q= X-Google-Smtp-Source: ABdhPJzODnwezNxIAQ0ZwBXC+h8ctAdGbNWIOvIpmoEChvM3cQ8tJFruEf/TqobjCCEtriRSpj7pCg== X-Received: by 2002:aa7:dc4e:: with SMTP id g14mr4513438edu.346.1591832663740; Wed, 10 Jun 2020 16:44:23 -0700 (PDT) Received: from ?IPv6:2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8? ([2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8]) by smtp.gmail.com with ESMTPSA id ws10sm772278ejb.24.2020.06.10.16.44.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2020 16:44:23 -0700 (PDT) Subject: Re: svn commit: r362017 - in head/usr.bin/sed: . tests To: Yuri Pankov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202006101923.05AJNwPt006602@repo.freebsd.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-ID: <52a575ff-73aa-68a4-c3e7-5b518233ffc7@FreeBSD.org> Date: Thu, 11 Jun 2020 01:44:21 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 49j3Vd504tz3TFV X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-2.13 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-0.90)[-0.896]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.21)[-0.209]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.49:from]; NEURAL_HAM_MEDIUM(-1.02)[-1.025]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.49:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2020 23:44:26 -0000 On 6/10/20 11:44 PM, Yuri Pankov wrote: > Mateusz Piotrowski wrote: >> Author: 0mp (doc,ports committer) >> Date: Wed Jun 10 19:23:58 2020 >> New Revision: 362017 >> URL: https://svnweb.freebsd.org/changeset/base/362017 >> >> Log: >>    Read commands from stdin when -f - is passed to sed(1) [...] >> Modified: head/usr.bin/sed/tests/sed2_test.sh [...] >>   atf_init_test_cases() >>   { >>       atf_add_test_case inplace_command_q >>       atf_add_test_case inplace_hardlink_src >>       atf_add_test_case inplace_symlink_src >>       atf_add_test_case escape_subst >> +    atf_add_test_case commands_on_stdin >> +    atf_add_test_case commands_on_stdin >> +    atf_add_test_case commands_on_stdin >>       atf_add_test_case hex_subst >>   } >> > > Am I reading it wrong, or is it the same test case added 3 times? Sigh, yes, it does not make any sense. Thanks for spotting. Removing those 2 extra lines should do, right? Can I commit it?