Date: Wed, 9 May 2001 01:09:43 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: arch@FreeBSD.org Subject: RE: Patch to eliminate struct pcred Message-ID: <Pine.NEB.3.96L.1010509010510.11741r-100000@fledge.watson.org> In-Reply-To: <XFMail.010507130340.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John, Thanks for your comments. As you point out, the srv4 exit change is replicated from your kern_exit change of similar ilk. It might be nice to revisit whatever rationale there was for breaking out the srv4 exit code, and see if we can just rely on a wrapped exit1(), which is the approach taken by the linuxulator. This would reduce code replication. I've likewise removed the intrace cached process flag, and increased the size of the "there's a race condition here" warning in the execve() code. As noted in the comment, and as you've indicated, we need to address this more broad locking problems that result in security issues before we un-giat this and a number of other calls (in particular, any operations involving inter-process activities such as tracing, debugging, and signalling). While modifying the code, I cleaned up the sv[ug]id modification code there -- I need to dig up a copy of POSIX.1 to verify that the new (and the old) behavior are consistent with the requirements. I've also added a comment indicating that we may want to set P_SUGID in the event that we do update the saved id's. I've also updated the patch to take into account my recent posix4 commits. The revised patch is available at: http://www.watson.org/~robert/pcred.2.diff Tomorrow I plan to run some more heavy-duty tests, and re-review the code. After that, I'd like to go ahead and commit, assuming no further reviews will be coming in. Thanks, Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1010509010510.11741r-100000>