From nobody Tue Apr 14 19:53:50 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fwFMk1Jrfz6ZLbx; Tue, 14 Apr 2026 19:53:54 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fwFMk0ZsSz437Q; Tue, 14 Apr 2026 19:53:54 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776196434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=flU8VDeElTRRM8EMF3WFOProIRRBuMvxS8ZK8yS40aA=; b=eWs19X2q32iqLrZ5IU7CN1vgRpmV5V+DLjVkwCeUfj0JgJUoNFpLgJHfSJbvW8ySoSVyGu rjAU7r8vkAX6uyMx/8AsKWIP1ucITyh32DmzZKac5OJAr+x6Jgo8p378WhBRvpwdomgcCP BL3hh/DL3xJF5Vgom9ZsIh9y9OlfskbJxoTnKCUbKz2Uu/ZE7b7twDYiZOHHyKBYJfj7GS 6tC5DrWs4dKAGVRlCA2B3vPOTfLrkAGV6n9xwcwNEuwm0/FEh/rkiNhTXU1HMkI8uP/bqi P1B/To5DjeM7UzKSai4HuWUPtGPhuVSSSMeJ7yN9Qz4VdEK2q+jAoMiHRtkbDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776196434; a=rsa-sha256; cv=none; b=HXKojEK6k6m0fKGcyNZhhJPA0UvAt1DR0SrIB9HGHrJv0mJH6GTMUtAlMRreoULag/VrZA FsYQnS+LT308bW/p97yoe6N27gzsdXXauy2pVV2k+3TKgrpl7BpKAbgaRnxzwg4koscLah 0N7uIbuNIRwFyl7bSWts5eBgASB7fDvVz8HGVpmRH9Pdm4VaGCAZaWRLGi3wDY/CYN0abs mIEfhWD/7zOw42/zCf6V+b86LuuYAKHyr1fsaFPUl5rI/KWbRVPfdhPG032jBrNVZdUFLE DrG1pYVvWRv5cnTPGdr6s9vBlK++tyGHaq7dmJRnVHXgQYjchrOzOUVJHARYUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776196434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=flU8VDeElTRRM8EMF3WFOProIRRBuMvxS8ZK8yS40aA=; b=obsVVH2+rpqNwUOhOZgL/wHYuDXV/MsEmOXzTNPAFGb8hDDTsob7Duv4cqxv18MjOaqVKZ l+47Q54gc3LYQjpAaKSLsJU3f7USNXzvkV5zq0Tttqt3UaMGtEzDKrzfqT4pyccISvFBJf JP+dozfQXSnZG/t4olVXaK+aWpAak6exE5wgtmXKkYbccdRE/aHa9TUgxIVASSvUjJspKi JSbJJjhEElQGNXioUe5f/EMG5yjiHTMv1hR3EqcZA/zLKrgkVLGy8OoepXlLThk5S8S2m3 K8UG13JubADNytLY/OOLl9xzJnVOQJnZkiB+UEPNp+NWpZrIhGfPvWSfGQJxCA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fwFMj2PpMz8Xx; Tue, 14 Apr 2026 19:53:53 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 14 Apr 2026 12:53:50 -0700 From: Gleb Smirnoff To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets Message-ID: References: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> <1fcc8e29-5a8c-4596-91d9-8212ff8cc379@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1fcc8e29-5a8c-4596-91d9-8212ff8cc379@FreeBSD.org> On Tue, Apr 14, 2026 at 03:42:03PM -0400, John Baldwin wrote: J> > J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> J> > J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> Author: John Baldwin J> > J> AuthorDate: 2026-04-14 18:07:51 +0000 J> > J> Commit: John Baldwin J> > J> CommitDate: 2026-04-14 18:07:51 +0000 J> > J> J> > J> tcp_close: Use in6_pcbdisconnect for INET6 sockets J> > J> J> > J> This also fixes the LINT-NOINET builds. J> > J> J> > J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()") J> > J> > Thanks! I wonder how did it pass the tests. Looks like we don't have J> > any UDPv6 tests? J> J> If you look at in_pcbdisconnect and in6_pcbdisconnect they are mostly the same and J> given that it was a close operation about to discard the pcb anyway, the differences J> probably didn't matter in practice. I only noticed due to make tinderbox being broken. Indeed, since after this path socket can't be reused assignment to IPv4 part of the union was harmless for IPv6. -- Gleb Smirnoff