From owner-freebsd-mips@FreeBSD.ORG Wed Jan 26 11:52:59 2011 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D9ACC1065679 for ; Wed, 26 Jan 2011 11:52:59 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6E5FF8FC08 for ; Wed, 26 Jan 2011 11:52:59 +0000 (UTC) Received: by wyf19 with SMTP id 19so827053wyf.13 for ; Wed, 26 Jan 2011 03:52:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=l8HSYyP923k5wGQ4ms89dJ5IMD18sSoCqOsgqbTDFHQ=; b=fsvdlG9Jta69Xb8F3s6Sc/RiRRP87XH8jbDCvFPcYAkghUM7x7QoG8Y7GxKpeS+e+Z zD2nFLRr+tRp9k0Eb2t0YIxJC6OMbrfXSvI4ey0VV07vqD38+73WH+se555l6txImtBk PzpSo7/BNq8xsygQTXflmvHMduGOK7QBdRXMI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=l21dJ1tNAkHfshrikGxWbp9/Jc1L68BmOmxuUnH9edxy+SudwM6EwrkuIse/giCUlO rIgL4ghyZajpoIMTduZ0ZMElQmTAmYP5LlKwM6IUl5zlOakkIxij+J9ZGyO9SQqKj+cj eUsnSruXCzt5gdzzSjFmRVtEcqEtC6jPFC7P8= MIME-Version: 1.0 Received: by 10.227.156.10 with SMTP id u10mr1009847wbw.224.1296042778165; Wed, 26 Jan 2011 03:52:58 -0800 (PST) Received: by 10.227.196.195 with HTTP; Wed, 26 Jan 2011 03:52:58 -0800 (PST) In-Reply-To: <4D3F0B19.4060907@bsdimp.com> References: <4D3F0B19.4060907@bsdimp.com> Date: Wed, 26 Jan 2011 17:22:58 +0530 Message-ID: From: "Jayachandran C." To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: [PATCH] update sf_buf and uio for n64 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2011 11:52:59 -0000 On Tue, Jan 25, 2011 at 11:10 PM, Warner Losh wrote: > On 01/25/2011 06:48, Jayachandran C. wrote: >> >> This is one of the remaining pieces in n64 work from Juli's octeon >> branch. The attached patch updates the sf_buf code and uio_machdep.c >> in n64 compilation to use direct mapping. >> >> Planning to check this in later this week, if there are no objections. >> >> JC. > > I really like the uio_machdep.c. =A0I think it is good and can go in with= out > further objection. > > I like the idea of the n64 direct mapping of the sbufs. =A0That's a good > optimization. =A0I get nervous when I see some code implemented in one pl= ace > on one ifdef branch, and in a completely different file for another. =A0I= s the > gain in efficiency sufficient to justify this odd split? =A0If not, then > having all the code in vm_machdep.c might make more sense. =A0If the gain= is > enough, then having a comment in vm_machdep.c pointing to sf_buf.h would = be > good to have as well... (that's assuming the simplifications suggested by > Andrew Duane don't change the code distribution). Not sure what you mean here, the implementation of sf_buf_kva() and sf_buf_page() are in sf_buf.h, and the sf_buf_{init,alloc,free} are in vm_machdep.c as before. JC.