From nobody Thu Jun 4 21:09:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gWcf11sPpz6gxNq for ; Thu, 04 Jun 2026 21:10:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gWcdz0Rjkz3K7M for ; Thu, 04 Jun 2026 21:09:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=H9qVbt1K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::629 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2c0c35980fdso12229585ad.2 for ; Thu, 04 Jun 2026 14:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780607393; x=1781212193; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Z1XoAvOieeDZl/QidkfxcIFt9FxB3kH1bEkZuyHGmMg=; b=H9qVbt1K2qvPCxzkP6mIpGh/vptivmIP7AFbWjIGcE358GPY3gGqLUzP2gLLNv8lT3 NaiY4TgX6Y+E+Ta3IOzQuvd9XZj5N4CoPKXG+2zLwu5x5dfqXfIY8PXaKMo3AJRqv/nF zAQGi56KnS1mHnjYXyE11xBjRr6NuoT9MX2ZzYa6LfHxlupIhMAZelTzZaffM43xO9v7 HFiDDrQdslBEwlPjE9wZwqwOCmLMd76sTrDrkJ+MpruHCJy0S6v1T5LYptj+7RijRB98 ZibNkrRMpeXpKqpqNmSt8uB1B6lR6J8A3rq+UnvG1E4b5KZ+KuHfGfOWt+4By0NU78ro WxaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780607393; x=1781212193; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z1XoAvOieeDZl/QidkfxcIFt9FxB3kH1bEkZuyHGmMg=; b=c9bwc/DN7C/rbEL+W4gcV0tlAOHQZXYzRz5npAYLCLCWymNxiMAOQgCftQxiUQ8+kH d9XV/RL7cK5RD1gNkUZg+vwqGHcY9fFuk7iQFF/ZU6BkPZiOOIxtt5i0zRUtfoMRAJHH jPsH4Y/IFIbMKCNu6NfhOu5wA6Mm2DFQXgz2cwH/UUQTykdu9ibQeKGfn5FJ/xmHb3JN Jyh4R0gisRN6+9uO8kIlrEpFveQ6t+wSrSky/zxmdUzJhkL9Bx4UZK95AytX3JcHwDS5 Y6WFEJhiywNWPUkPCJVCW4rchqAdv3XNLnBQQFao4y3YolSbuaos7ql5fVzh1WVKtjZw RYIw== X-Forwarded-Encrypted: i=1; AFNElJ8P05G3MW2WrJ9WGD0iylaOPfB/BFK52p0tNOvMuhVbdktc88FMygcCPLae2HuJTK+J8h9LNfFPtKA6Han2CgDQlF8N@freebsd.org X-Gm-Message-State: AOJu0Yz2zyKEI/KEbD5oPh0kmDuybcsSCqw+wo6iylVX8pQiG4wfUG4S QuYRRN7pvGNFLlm96Cvrxp1G8+qDAIY4c8JuYUGL2B/M/W+4NqHfw+QF X-Gm-Gg: Acq92OFREXNVt8ehWdMt5vHxVyufvQLbEPhEShXSEte5AN6uFwUlzNTQ+QsZ11pK9yX gou2lVKkpDRdQ1E5aZx5hsRJiLH+S0yc3Tc20qYYXjDzev519hOEIOfRl0Ihoaf2vNHb1CoTSRf 0yw23dtivDMOl+3ANmV+z1bIQsuQE7V+Ylsg76t5TTiIsoAMUaUnUY0c57QTcDb0onpASIOPy8S z9XhSN/4bSPoNKstIvnHNjv06JfW25sxm31t5fi3XSZLZVFY4Qkqr8M13W4L8UoewIcySEOzIH6 P3bY1B5OJh37JnXXfA7pVQ2/qgka9I5c4MKfwd0f6X+f7wxd1tY4G1B1kj3568mIhlvqvhnNaO3 sTB0p/gnXmFduvP3eDT9yA/nzizmatK6oQfdA8yAtBGyvvA3nBiDk/eFfqeaRXbtnCNq5+Dj66B D/1e1vWf41aT6gvpImGHdOW+/IkamJZ7vpicKMCwXU8DxB+nQ8EXEc5aIc X-Received: by 2002:a17:903:22c9:b0:2bf:2015:5b93 with SMTP id d9443c01a7336-2c1e82125f8mr2892685ad.11.1780607392831; Thu, 04 Jun 2026 14:09:52 -0700 (PDT) Received: from smtpclient.apple ([185.228.19.36]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d2bbsm71144565ad.1.2026.06.04.14.09.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2026 14:09:51 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_247B5DFD-B56E-4B51-B212-DEF18C678864"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: git: 886164895f3f - main - amd64: complete thunderbolt KERNCONF integration From: "Enji Cooper (yaneurabeya)" In-Reply-To: <3174612.hHqAuc6tWs@ravel> Date: Thu, 4 Jun 2026 14:09:40 -0700 Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Message-Id: <4316E349-244A-4F3E-9D4B-538EE4B0F037@gmail.com> References: <6a1fc36c.20f4d.2792bff2@gitrepo.freebsd.org> <86wlwgue2o.fsf@ltc.des.dev> <3174612.hHqAuc6tWs@ravel> To: Olivier Certner X-Mailer: Apple Mail (2.3864.600.51.1.1) X-Spamd-Result: default: False [-5.46 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.86)[-0.863]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::629:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[6] X-Spamd-Bar: ----- X-Rspamd-Queue-Id: 4gWcdz0Rjkz3K7M --Apple-Mail=_247B5DFD-B56E-4B51-B212-DEF18C678864 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 3, 2026, at 9:06=E2=80=AFAM, Olivier Certner = wrote: >=20 > Hi Enji, >=20 >>> commit 886164895f3f4805dc11171ac7980acaccf6ec77 >>> Author: Enji Cooper >>> AuthorDate: 2026-06-03 06:02:01 +0000 >>> Commit: Enji Cooper >>> CommitDate: 2026-06-03 06:02:01 +0000 >>>=20 >>> amd64: complete thunderbolt KERNCONF integration >>>=20 >>> This completes the work so the driver can be integrated into = KERNCONFs >>> properly on amd64. >>>=20 >>> MFC after: 1 month >>>=20 >>> Differential Revision: https://reviews.freebsd.org/D55573 >>=20 >> /usr/src/sys/dev/thunderbolt/router.c:281:6: error: variable 'up' set = but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/router.c:723:8: error: variable 'adap' = set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/nhi.c:837:20: error: variable 'sc' set = but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/nhi.c:871:20: error: variable 'sc' set = but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/nhi.c:874:8: error: variable 'len' set = but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/tb_acpi_pcib.c:123:15: error: variable = 's' set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/tb_pcib.c:307:6: error: variable 'error' = set but not used [-Werror,-Wunused-but-set-variable] >=20 > Compilation fails on INVARIANTS, it works with !INVARIANTS. Was = bitten by such a case relatively recently. Try not to forget to build = both cases when fiddling with debug code. >=20 > Fixed in 9a133eee1ed9cf32. Amend as you see fit. Thank you Olivier. I=E2=80=99m kind of surprised that __diagused didn=E2=80=99t work, but = what you did is the right thing to do in this case. I=E2=80=99ll MFC your change as well when the time comes to MFC my = original change. Cheers, -Enji= --Apple-Mail=_247B5DFD-B56E-4B51-B212-DEF18C678864 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmoh6ZQACgkQGpE5DjPs NJg/bw//WtGPrMjKrOyQPrzR0lXtOfrbWP4/JEIpyTl06UA9qGu/zGzdJQwcrvwM J6ilkjnb1vs3akG9raVVuiJm7jEjQP7RvQPyVM8eCqNMa9S4RZBwUEF4hjCX0hkO fUsILExXj/S3ztH5PIDq/1Axk5A49gD/WKZmUW4wEc/OQaE7JGlMtaG9k9HV1Kh6 BmlsN55MWjAS43XrkBbsMbJpSWBE3pfdiH6i460DMDstZ6r2fdky9ULWugDUvDvW 1i0I3kMh4qji8oXoc1WANum5DMLMWF5xw00lRD420yOsxKGna9E1OUZsn3sCfIEy UEb52h7Jv5LyckABYW15h04yJkfP62UdlYYcA4mPpUaJrNFZ21Cteamb/qIPWm4r K0UE1n3ScX0gu33bwiZcyzsj4hTHMCWgVOaEygE9xZfZUcWJVSnj1GjQFZ7qHyqR DnM3wGjk6ar9LWGUesltiKV2pbUfNpfOI1MXW56Lvqat165FFsEMnlH75OX9ldha NhKRvsbN6W3s+Gv33SljkEj/atooxx3S0jWIxHL+7CCGhKXU7K54qFxV5tdeDrax 8gIgTvMq7SSiWaMGSrnUh322zKWljJKkVixr42/GAlFklA0S59I/rqol/m6j0FVm owYQ8gP0SnjoNnZeoL45kyrw7/JraGRtYglt51PJbh22yGZAMKU= =R0tR -----END PGP SIGNATURE----- --Apple-Mail=_247B5DFD-B56E-4B51-B212-DEF18C678864--