From owner-freebsd-arm@freebsd.org Thu Jan 16 14:43:33 2020 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8521A1EA408 for ; Thu, 16 Jan 2020 14:43:33 +0000 (UTC) (envelope-from nikolay.kostirya@i11.co) Received: from mx.i11.co (mx.i11.co [159.69.78.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47z6Pw3JG4z45rL; Thu, 16 Jan 2020 14:43:32 +0000 (UTC) (envelope-from nikolay.kostirya@i11.co) Received: from [82.207.42.188] (helo=localhost) by mx.i11.co with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1is6Mm-0005Rd-7z; Thu, 16 Jan 2020 14:43:24 +0000 Date: Thu, 16 Jan 2020 16:43:21 +0200 From: Nick Kostirya To: Ian Lepore Cc: Milan Obuch , freebsd-arm@freebsd.org Subject: Re: gpioiic FDT overlays for sun8i-h3 Message-ID: <20200116164321.68d6a219@i11.co> In-Reply-To: <78c7d14bb681f8bca11525bf61cf871c6e89c235.camel@freebsd.org> References: <20191128152901.39dbeb4d@thinkpad> <20191128062149.577be86eb7dc15ae5805f31a@bidouilliste.com> <20191129153754.28fb5763@thinkpad> <20191129144316.739c8664@zeta.dino.sk> <20191129155431.05d4e14f@thinkpad> <20191129150944.67a2b723a6724c46f7559f96@bidouilliste.com> <0ce78262af1dd3b404b9a85a780933d7e11f008e.camel@freebsd.org> <20191129201244.0bc85b09@thinkpad> <20191219095935.6fed7431@i11.co> <78c7d14bb681f8bca11525bf61cf871c6e89c235.camel@freebsd.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i386-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47z6Pw3JG4z45rL X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[i11.co:s=omicron]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:159.69.78.69]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; SH_EMAIL_ZRD(0.00)[0.0.0.0,0.0.0.1]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[i11.co:+]; DMARC_POLICY_ALLOW(-0.50)[i11.co,reject]; SH_EMAIL_DBL_DONT_QUERY_IPS(0.00)[0.0.0.1,0.0.0.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-2.08)[ip: (-9.59), ipnet: 159.69.0.0/16(0.74), asn: 24940(-1.51), country: DE(-0.02)]; ASN(0.00)[asn:24940, ipnet:159.69.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2020 14:43:33 -0000 On Thu, 19 Dec 2019 10:29:16 -0700 Ian Lepore wrote: > > The gpioiic node needs to be defined at the root of the devicetree, not > under the pinctrl node. Assuming that all pins are configured as gpios > by default (they are on most SOCs) you probably don't need a pinctrl > node for them at all. If you do, someone who knows allwinner stuff > better than me would have to provide an example of that part. > > To add the gpioiic driver node using pins 0 and 2 like your example, I > think it should be just this: > > /dts-v1/; > /plugin/; > > / { > compatible = "allwinner,sun8i-h3"; > }; > > &{/} { > gpioiic@0 { > compatible = "i2c-gpio"; > scl-gpios = > <&pio 0 0 GPIO_ACTIVE_HIGH>; > sdl-gpios = <&pio 0 2 > GPIO_ACTIVE_HIGH>; > }; Hello. This is me again. I have gpioiic0 and I wanted to add another gpioiic (gpioiic1): gpioiic@1 { compatible = "i2c-gpio"; scl-gpios = <&pio 0 22 GPIO_ACTIVE_HIGH>; /* GPIO pin 22 (PC0) */ sda-gpios = <&pio 0 23 GPIO_ACTIVE_HIGH>; /* GPIO pin 23 (PC1) */ }; But I got error in dmesg: gpiobus0: invalid pin -1058976448, max: 93 Must gpioiic be only one? Nick.