From owner-cvs-src@FreeBSD.ORG Mon May 28 11:11:53 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1BDC016A46C; Mon, 28 May 2007 11:11:53 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.130]) by mx1.freebsd.org (Postfix) with ESMTP id 8E5C313C4B0; Mon, 28 May 2007 11:11:52 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.1/8.14.1) with ESMTP id l4SBBlHD000440; Mon, 28 May 2007 15:11:47 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.1/8.14.1/Submit) id l4SBBlor000439; Mon, 28 May 2007 15:11:47 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 28 May 2007 15:11:47 +0400 From: Gleb Smirnoff To: "M. Warner Losh" Message-ID: <20070528111147.GN89017@FreeBSD.org> References: <46569762.6090801@freebsd.org> <20070525090951.F53865@fledge.watson.org> <46575362.1050005@freebsd.org> <20070525.165823.29499700.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20070525.165823.29499700.imp@bsdimp.com> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: rwatson@FreeBSD.org, src-committers@FreeBSD.org, andre@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2007 11:11:53 -0000 On Fri, May 25, 2007 at 04:58:23PM -0600, M. Warner Losh wrote: M> : during program debugging. Everything below LOG_NOTICE should not M> : need fsync after each line. An examination of all users of LOG_DEBUG M> : in our kernel doesn't show anything critical that would require fsync. M> : The attached patch fixes syslog.conf in this regard. M> M> /var/log/debug.log doesn't exist by default. True, so the second chunk of the patch isn't necessary. M> Also, this patch removes M> *ALL* kernel messages from /var/log/messages, which isn't right M> either. Yes, only kern.notice messages will be logged. Andre probably wants to change kern.debug to kern.info. I don't really agree with this suggestion. In this case all the kern.debug messages will be lost, so what is the sense in improving the debugging verbosity of the kernel, if we don't log it anywhere? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE