From owner-freebsd-bugs@freebsd.org Tue Jul 19 12:30:52 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66A83B9DA13 for ; Tue, 19 Jul 2016 12:30:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3D49F1A0C for ; Tue, 19 Jul 2016 12:30:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6JCUqjm012622 for ; Tue, 19 Jul 2016 12:30:52 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 211225] [PATCH]: CRASH: telnetd crashes periodically Date: Tue, 19 Jul 2016 12:30:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marcus@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 12:30:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211225 Bug ID: 211225 Summary: [PATCH]: CRASH: telnetd crashes periodically Product: Base System Version: 10.3-STABLE Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: marcus@FreeBSD.org Keywords: patch Created attachment 172719 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172719&action= =3Dedit Patch to fix telnetd crash Yes, I still have telnetd running (though I don't use it). Periodically, it crashes. I've tracked this down to a NULL pointer defref. Attached is a p= atch that fixes the crash. The backtrace I see is: #0 0x0000000000405657 in telrcv () at /usr/src/libexec/telnetd/../../contrib/telnet/telnetd/state.c:231 231 ch =3D *slctab[SLC_EL].sptr; (gdb) bt #0 0x0000000000405657 in telrcv () at /usr/src/libexec/telnetd/../../contrib/telnet/telnetd/state.c:231 #1 0x000000000040a149 in ttloop () at /usr/src/libexec/telnetd/../../contrib/telnet/telnetd/utility.c:88 #2 0x0000000000407055 in doit (who=3D0x7fffffffeb90) at /usr/src/libexec/telnetd/../../contrib/telnet/telnetd/telnetd.c:510 #3 0x0000000000407aa8 in main (argc=3D, argv=3D0x7fffffffec98) at /usr/src/libexec/telnetd/../../contrib/telnet/telnetd/telnetd.c:413 (gdb) print slctab $1 =3D {{defset =3D {flag =3D 0 '\0', val =3D 0 '\0'}, current =3D {flag = =3D 0 '\0', val =3D 0 '\0'},=20 sptr =3D 0x0} } (gdb) print *slctab $2 =3D {defset =3D {flag =3D 0 '\0', val =3D 0 '\0'}, current =3D {flag =3D= 0 '\0', val =3D 0 '\0'}, sptr =3D 0x0} (gdb) print *slctab[SLC_EL] No symbol "SLC_EL" in current context. (gdb) print *slctab[11]=20=20=20=20 Structure has no component named operator*. (gdb) print slctab[11] $3 =3D {defset =3D {flag =3D 0 '\0', val =3D 0 '\0'}, current =3D {flag =3D= 0 '\0', val =3D 0 '\0'}, sptr =3D 0x0} (gdb) print *slctab[11] Structure has no component named operator*. (gdb) print *slctab[11].sptr Cannot access memory at address 0x0 --=20 You are receiving this mail because: You are the assignee for the bug.=